-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[saffron] Add Read Proof #3016
Open
martyall
wants to merge
12
commits into
martin/saffron-separate-query-module
Choose a base branch
from
martin/saffron-read-pf
base: martin/saffron-separate-query-module
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[saffron] Add Read Proof #3016
martyall
wants to merge
12
commits into
martin/saffron-separate-query-module
from
martin/saffron-read-pf
+697
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
f69a1de
to
528f44c
Compare
528f44c
to
3148555
Compare
Saffron: simplify decoder
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## martin/saffron-separate-query-module #3016 +/- ##
========================================================================
+ Coverage 76.84% 77.07% +0.23%
========================================================================
Files 263 264 +1
Lines 62191 62348 +157
========================================================================
+ Hits 47791 48056 +265
+ Misses 14400 14292 -108 ☔ View full report in Codecov by Sentry. |
a6221b8
to
dbbef7d
Compare
e5bd6e9
to
f8688e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my_data[start..end]
), not a random subset of indices. I discussed this with @marcbeunardeau88 as being the easiest thing to do that was useful.proof
module namespace, i.e.TODO
This currently creates a "trivial" read proof for a given chunk if that chunk doesn't contain any of the query indices (effectively 0 == 0) . There is surely a smarter / faster way to do this using
Option
that is also sound, proposing to do in a follow up PR.