Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saffron] Add Read Proof #3016

Open
wants to merge 12 commits into
base: martin/saffron-separate-query-module
Choose a base branch
from

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Feb 12, 2025

  • Add functionality for creating / verifying read proofs according to @marcbeunardeau88 's diagram. NOTE: This only works for slice reads right now (think of the form my_data[start..end]), not a random subset of indices. I discussed this with @marcbeunardeau88 as being the easiest thing to do that was useful.
  • Add prop tests to check on random data with random queries
  • Add a proof module namespace, i.e.
saffron/src/proof
├── mod.rs
├── read.rs
└── storage.rs

TODO

This currently creates a "trivial" read proof for a given chunk if that chunk doesn't contain any of the query indices (effectively 0 == 0) . There is surely a smarter / faster way to do this using Option that is also sound, proposing to do in a follow up PR.

@martyall martyall marked this pull request as ready for review February 12, 2025 09:11
@martyall martyall force-pushed the martin/saffron-read-pf branch from f69a1de to 528f44c Compare February 12, 2025 09:29
@martyall martyall force-pushed the martin/saffron-read-pf branch from 528f44c to 3148555 Compare February 12, 2025 09:35
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (7da4dc0) to head (304b505).

Files with missing lines Patch % Lines
saffron/src/main.rs 0.00% 3 Missing ⚠️
saffron/src/proof/read.rs 98.66% 2 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           martin/saffron-separate-query-module    #3016      +/-   ##
========================================================================
+ Coverage                                 76.84%   77.07%   +0.23%     
========================================================================
  Files                                       263      264       +1     
  Lines                                     62191    62348     +157     
========================================================================
+ Hits                                      47791    48056     +265     
+ Misses                                    14400    14292     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall force-pushed the martin/saffron-read-pf branch from a6221b8 to dbbef7d Compare February 15, 2025 04:58
@Fizzixnerd Fizzixnerd force-pushed the martin/saffron-separate-query-module branch from e5bd6e9 to f8688e7 Compare February 18, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants