Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/lookup: prover takes cm wires as arg #3054

Open
wants to merge 3 commits into
base: marc/lookup-main
Choose a base branch
from

Conversation

marcbeunardeau88
Copy link
Contributor

the lookup prover does not commit to the lookup state, as it is already done in the first loop, while doing the main proofs

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.91%. Comparing base (c45956b) to head (67c114d).

Files with missing lines Patch % Lines
o1vm/src/pickles/lookup_prover.rs 0.00% 14 Missing ⚠️
o1vm/src/pickles/main.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           marc/lookup-main    #3054      +/-   ##
====================================================
- Coverage             75.93%   75.91%   -0.02%     
====================================================
  Files                   265      265              
  Lines                 62726    62740      +14     
====================================================
+ Hits                  47629    47630       +1     
- Misses                15097    15110      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant