Foreign field addition #578

mrmr1993 · 2022-05-26T21:21:56Z

This PR is a first-pass implementation of foreign field addition.

TODO:

unify naming
gate creation

Closes #682

querolita · 2022-07-13T14:59:32Z

I have drafted this hackmd explaining foreign field addition. We are using a slightly different notation, but I think it depicts the same idea Matthew had.

kimchi/src/circuits/gate.rs

kimchi/src/circuits/constraints.rs

kimchi/src/circuits/gate.rs

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs

…yntax

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs

kimchi/src/circuits/polynomials/foreign_field_add/gadget.rs

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs

book/src/rfcs/ffadd.md

kimchi/src/tests/foreign_field_add.rs

…esta

…t prime

jspada

Looks great!

mrmr1993 and others added 12 commits May 26, 2022 21:02

Add ForeignFieldAdd selector

3869bf9

Add foreign field addition gate with TODOs for foreign modulus

d5c2aa6

Add foreign_field_modulus to constraint system

de4ab83

Tweak position of upper_bound_carry_check_{0,1}

3b7b3aa

Add witness generation helper

6cc070a

Add constraints when foreign field addition selector is enabled

3bff269

Fixup test compilation

63da2dc

Merge branch 'master' into feature/foreign-field-addition

06e0270

Rename foreign field add and fixup formatting

3cf56a7

Update name to foreign_field_add

32259b7

Fix clippy errors and update spec

a7c6f9a

Update specification using new version of cargo-spec

13c22ae

querolita added 7 commits July 13, 2022 17:36

change number of constraints

2a5b0ce

update constraint cound and add some docs

c9a2896

move code structure to folder

6a5368a

fix path route

c5fa4b2

switch to ffmul format for gadget and pf system params

694faf9

trying to fix doc errors, still not passing tests

1ded357

Merge branch 'master' into feature/foreign-field-addition

aa2031e

mrmr1993 commented Jul 14, 2022

View reviewed changes

kimchi/src/circuits/gate.rs Outdated Show resolved Hide resolved

kimchi/src/circuits/constraints.rs Show resolved Hide resolved

kimchi/src/circuits/gate.rs Outdated Show resolved Hide resolved

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs Outdated Show resolved Hide resolved

querolita added 9 commits July 15, 2022 12:00

unify notation in little endian lo mi hi

323f812

address Matthew's comments

46882a9

using witness layout as in range check and ffmul

2b2ba37

fix warnings CI

fddd6ff

intentionally does not compile, just an intermediate version of the s…

4c52ebe

…yntax

unable to modify content of struct this way, will rewrite this part

ef82b4c

compiles with ForeignElement type

291b9cb

fixing some errors for the tests

00d9c20

first test, fixed constraints

16de509

jspada reviewed Sep 26, 2022

View reviewed changes

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs Outdated Show resolved Hide resolved

jspada reviewed Sep 26, 2022

View reviewed changes

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs Outdated Show resolved Hide resolved

jspada reviewed Sep 26, 2022

View reviewed changes

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs Outdated Show resolved Hide resolved

jspada reviewed Sep 26, 2022

View reviewed changes

kimchi/src/circuits/polynomials/foreign_field_add/gadget.rs Show resolved Hide resolved

querolita added 2 commits September 26, 2022 14:09

address joseph's comments

d9ec85e

change panic for println

1bd25e7

mrmr1993 commented Sep 26, 2022

View reviewed changes

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs Outdated Show resolved Hide resolved

querolita added 5 commits September 26, 2022 17:28

typo

eb7c484

fixed version with only one gate

25ee8e6

Merge branch 'master' into feature/foreign-field-addition

6797bdf

change name of pallas and vesta

198883d

update specs

9b7ca9e

mrmr1993 commented Sep 26, 2022

View reviewed changes

kimchi/src/circuits/polynomials/foreign_field_add/circuitgates.rs Outdated Show resolved Hide resolved

querolita added 3 commits September 27, 2022 11:23

switch positions of witness to have sign in <7

f3be948

Merge branch 'master' into feature/foreign-field-addition

b8b954f

remove lo mi hi and implement index for foreignelement

e2200dc

jspada reviewed Sep 28, 2022

View reviewed changes

kimchi/src/tests/foreign_field_add.rs Outdated Show resolved Hide resolved

querolita added 8 commits September 29, 2022 18:23

address 95% of joseph's final comments

6cb9089

helper for max values of fields instead of hardcoded for pallas and v…

dcd433e

…esta

derive eq as well

728c070

unify test pattern

5a3b25e

added random tests and foreign field being pallas, ff mod being 200bi…

e963a33

…t prime

new tests for bad parameters (and todo with sign ovf for final check)

4de646a

test for long chain of random operations

12f1497

final test with prover and verifier

a2f5899

jspada self-requested a review October 6, 2022 17:34

jspada approved these changes Oct 6, 2022

View reviewed changes

querolita merged commit b51a5b4 into master Oct 6, 2022

querolita deleted the feature/foreign-field-addition branch October 6, 2022 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Foreign field addition #578

Foreign field addition #578

mrmr1993 commented May 26, 2022 •

edited by querolita

Loading

querolita commented Jul 13, 2022 •

edited

Loading

jspada left a comment

Foreign field addition #578

Foreign field addition #578

Conversation

mrmr1993 commented May 26, 2022 • edited by querolita Loading

querolita commented Jul 13, 2022 • edited Loading

jspada left a comment

Choose a reason for hiding this comment

mrmr1993 commented May 26, 2022 •

edited by querolita

Loading

querolita commented Jul 13, 2022 •

edited

Loading