Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snarkyjs: Reduce loading time #829

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Snarkyjs: Reduce loading time #829

merged 7 commits into from
Aug 22, 2023

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Aug 17, 2023

supports o1-labs/o1js#1073

  • make computation of field size bits lazy so it doesn't block web page loading
    • Z.testbit is very slow. In the near future I hope to put more performant js implementations in place, and changes like this one will no longer be necessary
  • use Field.to_string and Field.of_string from the bindings instead of implementing it via to_bignum_bigint and Bignum_bigint.to_string
    • this just makes sense, because it gives us the flexibility of optimizing the implementation in JS
    • just a glimpse of many future similar changes that I'd like to do, avoiding the zarith bigint stubs which are slow

@mitschabaude mitschabaude merged commit fa2cb9b into master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants