Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per query filters #135

Merged
merged 11 commits into from
Nov 14, 2023
Merged

Support per query filters #135

merged 11 commits into from
Nov 14, 2023

Conversation

epugh
Copy link
Member

@epugh epugh commented Nov 8, 2023

This is still pretty draft....

@epugh epugh requested a review from mkr November 8, 2023 19:55
@epugh epugh marked this pull request as draft November 8, 2023 19:55
epugh and others added 2 commits November 10, 2023 10:08
* Supports query templates as Strings or Objects now
* Supports arbitrary #$key## style keys and #$key.x## notation for sub-property access
* Currently exposing query, keywords (for back compat) and qOption (for nested query options) parameters
* Supports #$key.x## access to array indices
* Supports #$key|default## for injecting default values in case key is missing in the template
@mkr mkr force-pushed the support_per_query_filters branch from a421d90 to 143f114 Compare November 13, 2023 22:03
@mkr mkr marked this pull request as ready for review November 13, 2023 22:07
@epugh
Copy link
Member Author

epugh commented Nov 14, 2023

I wonder if we need some docs on template in the README?

@epugh epugh merged commit a6ec06e into main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants