Fix missing custom headers for searchapi endpoints #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
approved these changes
Nov 27, 2023
Yeah, totally, it seems to be handling some cross cutting concerns. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in o19s/quepid#890, when setting up an
apisearchendpoint, no custom headers are ever sent by the browser.In this PR I update the
searchapiSearcher to get headers the same way theesSearcher does and pass them along to the transport.In my reading, this was the only Searcher not propagating these headers. I re-used
esUrlSvc.getHeadersas this service was already in use in thesearchapiSearcher.