Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The escaping queries appears to be no longer fully working and may not be useful to "real users". #147

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

epugh
Copy link
Member

@epugh epugh commented Feb 2, 2024

See this bug o19s/quepid#910 and I also ran into weirdnesses while working on the snapshot support for looking up docs from a stored snapshot...

@epugh
Copy link
Member Author

epugh commented Feb 2, 2024

@softwaredoug does this spark any memories? I am thinking of removing the whole config.escapeQueries.... From Quepid and splainer-search...

@epugh
Copy link
Member Author

epugh commented Feb 3, 2024

I am going to merge this, just to try out a version of splainer-search and quepid.. if it doesnt' work, I'll revert it and re-release. And lastly, if it works then later we'll clean out all the "SUSS_USE_OF_ESCAPING" related code!

@epugh epugh merged commit 232bc07 into main Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant