Fixed the 'ptr_arg' clippy warning

Relevant lint: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
o2sh · Oct 31, 2019 · 065d65a · 065d65a
1 parent d868275
commit 065d65a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/ascii_art.rs b/src/ascii_art.rs
@@ -155,7 +155,7 @@ impl<'a> Tokens<'a> {
         })
     }
     /// render a truncated line of tokens.
-    fn render(self, colors: &Vec<Color>, start: usize, end: usize, bold: bool) -> String {
+    fn render(self, colors: &[Color], start: usize, end: usize, bold: bool) -> String {
         assert!(start <= end);
         let mut width = end - start;
         let mut colored_segment = String::new();
@@ -169,7 +169,7 @@ impl<'a> Tokens<'a> {
                     colored_segment.push(chr);
                 }
                 Token::Color(col) => {
-                    add_colored_segment(&mut whole_string, &colored_segment, color, bold);
+                    add_colored_segment(&mut whole_string, &colored_segment, *color, bold);
                     colored_segment = String::new();
                     color = colors.get(col as usize).unwrap_or(&Color::White);
                 }
@@ -180,7 +180,7 @@ impl<'a> Tokens<'a> {
             };
         });
 
-        add_colored_segment(&mut whole_string, &colored_segment, color, bold);
+        add_colored_segment(&mut whole_string, &colored_segment, *color, bold);
         (0..width).for_each(|_| whole_string.push(' '));
         whole_string
     }
@@ -198,8 +198,8 @@ fn succeed_when<I>(predicate: impl FnOnce(I) -> bool) -> impl FnOnce(I) -> Optio
     }
 }
 
-fn add_colored_segment(base: &mut String, segment: &String, color: &Color, bold: bool) {
-    let mut colored_segment = segment.color(*color);
+fn add_colored_segment(base: &mut String, segment: &str, color: Color, bold: bool) {
+    let mut colored_segment = segment.color(color);
     if bold {
         colored_segment = colored_segment.bold();
     }