hard to read on light background #33
Comments
|
Yeah, unfortunately as dark colors don't show well on black background, light colors are hard to read on white background. I don't see how i could please everyone... Thx for your feedback @bugabinga |
That would be hard indeed :) However, how about these alternatives: $ onefetch --color=auto|light|dark|noneMaybe there is a way to use the default colors of the terminal emulator, though I admit, I don't know. |
|
One possible solution is to have a theme that uses ansi colors, as bat does:
Delta uses more or less the same solution because it uses bat themes: dandavison/delta#447 (comment) Is creating an ansi theme or using bat's ansi theme possible for onefetch? |
|
Themes definitely sounds like a fun idea! I would consider it a new feature instead of a resolution to this issue. Mainly because I consider this issue resolved already due to the below points.
Since onefetch/src/info/langs/language.rs Lines 175 to 323 in bc09db5 So the way I imagine themes working is that colors would be defined as primary, secondary, tertiary, etc., and these would replace color Basically, themes could be built-in versions of what would happen if you used |
This is a fair point, but I do not want to figure out which colors I need to change on every terminal program I use. Picking a theme per program isn't as onerous, especially if I can just pick the ansi theme for everything (and ideally do that in a config file so I don't have to call it with command line flags every time).
|
|
Oh yeah, that white-on-white is pretty hard to read (I actually prefer low contrast output like that, but I know that's not the majority opinion 😆). So I think I've been thinking about this the wrong way. I was focused on the logo, but really it seems like the text is the issue. As a very quick workaround for you, Looks like your theme keeps black as dark and white as light, but other light themes, like Gruvbox Light, make black the light color and white the dark color (this is why I thought it was resolved). So, if we add themes, we'll at minimum probably need 2 light themes to handle terminal themes that do reverse black and white and themes that don't reverse them. |
Disappointingly, this doesn't seem to do it either:
The text is still too light to read. Here's some more info about my system:
My theme is Adwaita. P.S. Note that neofetch has no problem with this ;-) |
Without looking at their source code, I think I can guess why: they're probably using unstyled text for the info fields, while we default to using white (showing a bias for dark terminals). Made #593 based on this, so that you can at least disable some of the coloring for now and use your theme's foreground color 🙂 Also, I needed to add one more |
Allows the "white" color to have the greatest chance of being a dark, visible color for light terminal themes. A macro is used to remap `White` to `Default` to minimize size of the diff and prevent contributors from needing to be familiar with the `Default` color on top of the 8 standard colors. In other places where `White` was assumed to be the default, `Default` is now used instead, also. For #33 Closes #611
|
Since we've made a few PRs to address this, should this be closed? I think anything more would have to be done on a logo-by-logo basis. |
Thanks a lot for your time! |
In terminal emulators with light backgrounds, most of
onefetchs output is unreadable.The text was updated successfully, but these errors were encountered: