Use offset when getting time duration #1307
Conversation
spenserblack
force-pushed
the
bugfix/dropped-time-offset
branch
from
598e678
to
2a3707e
Compare
|
cc @Byron just confirming that |
| Ok(s) => s, | ||
| Err(_) => return "<before UNIX epoch>".into(), | ||
| Err(_) => return Err("<before UNIX epoch>".into()), |
There was a problem hiding this comment.
gitoxide supports times before unix epoch, but of course, there are dates outside of the valid range of i64.
| /// Gets the duration between `now` and `time`. Returns `Err` if this cannot be calculated. | ||
| fn diff_gix_time(now: SystemTime, time: Time) -> Result<Duration, String> { | ||
| let since_epoch_duration = now.duration_since(SystemTime::UNIX_EPOCH).unwrap(); | ||
| let ts = Duration::from_secs(match (time.seconds + i64::from(time.offset)).try_into() { |
There was a problem hiding this comment.
I'm a bit confused. Why do we need to consider the offset here? This method should simply return the difference between two UTC timestamps (without timezone): now (since epoch in UTC+0) - commit.time (since epoch in UTC+0.
Sorry if I'm mistaken.
There was a problem hiding this comment.
I made this with the assumption that #1306 was caused by differing timezones, which was an incorrect assumption, which made me assume that we were comparing a timezone-aware time to a naive time. Right now, personally, I am not sure if commit.time.seconds is UTC+0 or if it's a naive time that needs offset to get the real time.
There was a problem hiding this comment.
Sorry, I also didn't catch it. commit.time.seconds is UTC. The doc-string there unfortunately only implies it ("time in seconds since epoch."). I have fixed this here.
There was a problem hiding this comment.
Thanks! I guess this PR should be closed, then.
Related: #1306