-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of package manager module #350
Conversation
…etch into feature/macro_package_managers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all changes on various repos and it yields the expected behaviour. Code wise there are no logical changes except the macro, which looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This looks much cleaner with the macro 😄
With this PR, I introduced the
define_package_managers!
macro making it easier to add support for a new package manager.However, it doesn't handle #347 where you have multiple parsers per package manager.