Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of package manager module #350

Merged
merged 9 commits into from
Dec 20, 2020
Merged

Refactoring of package manager module #350

merged 9 commits into from
Dec 20, 2020

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Dec 17, 2020 •
edited
Loading

With this PR, I introduced the define_package_managers! macro making it easier to add support for a new package manager.

However, it doesn't handle #347 where you have multiple parsers per package manager.

@o2sh o2sh linked an issue Dec 17, 2020 that may be closed by this pull request
Refactoring of package manager module #349
Closed
@o2sh o2sh removed the request for review from spenserblack December 19, 2020 13:07
@o2sh
Copy link
Owner Author

o2sh commented Dec 19, 2020

43206c4 seems to cover #347

HallerPatrick
HallerPatrick approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@HallerPatrick HallerPatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all changes on various repos and it yields the expected behaviour. Code wise there are no logical changes except the macro, which looks good to me.

@HallerPatrick
Copy link
Contributor

43206c4 seems to cover #347

I will close #347

@HallerPatrick HallerPatrick linked an issue Dec 19, 2020 that may be closed by this pull request
Include look up for dependencies in pyproject.toml #345
Closed
spenserblack
spenserblack approved these changes Dec 20, 2020
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This looks much cleaner with the macro 😄

@o2sh o2sh merged commit 7de7cc2 into master Dec 20, 2020
@o2sh o2sh deleted the feature/macro_package_managers branch December 20, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

@HallerPatrick HallerPatrick HallerPatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring of package manager module Include look up for dependencies in pyproject.toml
3 participants
@o2sh @HallerPatrick @spenserblack