Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add language type #513

Merged
merged 2 commits into from
Oct 20, 2021
Merged

add language type #513

merged 2 commits into from
Oct 20, 2021

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Oct 20, 2021

fixes #510

spenserblack
spenserblack reviewed Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
You can ignore the comments without suggested changes: I commented because Jupyter and Vue are kind of a grey area for me so I wasn't sure if they should be considered markup or programming.

I think XML is a data language, though 🙂

src/info/langs/language.rs Outdated Show resolved Hide resolved
src/info/langs/language.rs Outdated Show resolved Hide resolved
src/info/langs/language.rs Outdated Show resolved Hide resolved
@spenserblack spenserblack mentioned this pull request Oct 20, 2021
Merged
@o2sh o2sh merged commit b98a26c into main Oct 20, 2021
@o2sh o2sh deleted the add-language-type branch October 20, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we handle data formats being the primary language?
2 participants
@o2sh @spenserblack