Added New "ParallaxDepthArtifacts" Screenshot Tests #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in parallax surfaces. I added a new setting to the Parallax sample that allows turning off all lights, so the surface is rendered black. This allows us to use a much tighter threshold on the screenshot comparison, since an entirely black unlit surface will not exhibit the sensitive platform differences we are used to seeing on parallax materials. This should ensure any depth-test calculation noise, which show up as gray firefly pixels, will cause the test threshold to fail. I included many screenshots because the noise seems to be platform - and/or driver-dependent, so having more screenshots increases the chances of detecting failures. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…ases where the IBL from one sample could persist when opening another sample, for example when going directly from the Mesh sample to the Parallax sample. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…c/FixingParallaxIssues Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
antonmic
approved these changes
Apr 23, 2022
amzn-tommy
reviewed
Apr 25, 2022
| OpenSample('Features/Parallax') | ||
| ResizeViewport(512, 512) | ||
|
|
||
| -- Several times there have bugs that appeared, related to inconsistent depth calculations causing unwanted clipping of pixels on parallax surfaces. |
There was a problem hiding this comment.
nit: have bugs->have been bugs
There was a problem hiding this comment.
Or even better
"Several times there have been bugs that appeared," -> "There have been several bugs related..."
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
amzn-tommy
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new screenshot tests that focus on exposing depth-test artifacts in parallax surfaces.
I added a new setting to the Parallax sample that allows turning off all lights, so the surface is rendered black. This allows us to use a much tighter threshold on the screenshot comparison, since an entirely black unlit surface will not exhibit the sensitive platform differences we are used to seeing on parallax materials. This should ensure any depth-test calculation noise, which show up as gray firefly pixels, will cause the test threshold to fail.
I included many screenshots because the noise seems to be platform - and/or driver-dependent, so having more screenshots increases the chances of detecting failures.
Also made sure any IBL is cleared when closing a sample. There were some cases where the IBL from one sample could persist when opening another sample, for example when going directly from the Mesh sample to the Parallax sample.
Corresponds to these code changes o3de/o3de#9135
The expected screenshots all look similar to this:
