Fix the 15th screenshot having root variant instead of fully baked #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com>
moudgils
approved these changes
Aug 15, 2022
santorac
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is introduced in #459
By removing the fix in the above PR, it still failed to changed the color, as the test was intended to do.
(Note some shader reload code was already removed in o3de/o3de#5142)
Intended failure without the fix:
Signed-off-by: jiaweig 51759646+jiaweig-amzn@users.noreply.github.com