Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website versioning #2087

Merged
merged 10 commits into from
Nov 23, 2022
Merged

Conversation

willihay
Copy link
Contributor

@willihay willihay commented Nov 15, 2022

Change summary

Includes:

  • Version switcher dropdown.
  • Version warning banner.
  • Preview info banner.
  • Update site.BaseURL to www.o3de.org.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

@netlify /docs/user-guide

Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay willihay marked this pull request as ready for review November 17, 2022 19:19
@willihay
Copy link
Contributor Author

Implements RFC o3de/sig-docs-community#54

Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@@ -1,4 +1,4 @@
baseURL = "https://o3de.org"
baseURL = "https://www.o3de.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be careful with this change and double check it doesn't impact our SEO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sptramer Would you know about this (and the other comment below)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like switching to www.o3de.org may actually improve our search and keep things pretty clean:

image

Comment on lines +33 to +34
["development", "https://development--o3deorg.netlify.app"],
["22.05", "https://2205--o3deorg.netlify.app"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to get subdomains for these? Like development.o3de.org and 2205.o3de.org

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is! We have to have the Linux Foundation set up the DNS records. So far we do not have a contact to do so, even after months of trying.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be best to just go live with the final subdomains, but I understand that it could mean waiting for a long time on this... so if the consensus is to use the temp ones in the meantime, I'm fine with it.

Question, does this change actually need to be applied on those versions of the site as well? Or do they share the same sass/js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will need to be merged / applied to every branch that is selectable in the dropdown (i.e. main, development, and 2205) - and eventually stabilization when that's created for the next release.

@willihay willihay requested a review from sptramer November 18, 2022 21:10
@sptramer sptramer removed their request for review November 23, 2022 00:55
@sptramer sptramer merged commit f5a1028 into o3de:main Nov 23, 2022
@sptramer sptramer deleted the willihay/website-versioning branch November 23, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/in-review Do not merge this PR. It is still being reviewed.
Projects
None yet
4 participants