Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to website versioning #2117

Merged
merged 15 commits into from
Nov 23, 2022
Merged

Enhancements to website versioning #2117

merged 15 commits into from
Nov 23, 2022

Conversation

willihay
Copy link
Contributor

@willihay willihay commented Nov 23, 2022 •
edited
Loading

Change summary

  • Move some CSS from HTML attributes to custom.sass.
  • Improve function that adjusts sidebar attributes to prevent unwanted scrolling.
  • Bug fix in <select> element updater function.
  • Page formatting updates.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

@willihay
Add version switcher dropdown functionality to docs navbar
df1495a 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Preliminary work includes version warning banner text
993cf6b 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Return spacing of unchanged html to previous position
a480836 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Add comments for draft PR
b41e920 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Move version dropdown and prevent left nav from scrolling
eaa214a 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Correct BaseURL in site config
2ef9709 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Add preview info banner and update conditional logic
f37c090 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Make local and preview into dynamic version options
cfceff9 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
JS fix
441a1f8 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Add version CSS, defaults, load from config
377d840 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Move some CSS from HTML attributes to custom.sass
cbfaf5b 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Improve function that adjusts sidebar attributes to prevent unwanted …
a0af512 
…scrolling

Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Resolve merge conflict
9b60aed 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
willihay
willihay commented Nov 23, 2022
View reviewed changes
layouts/partials/navbar.html
Comment on lines +11 to +12
<div class="sticky-top" id="docs-banners">
<div class="main-navbar navbar navbar-dark navbar-docs" role="navigation" aria-label="main navigation">
Copy link
Contributor Author

@willihay willihay Nov 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines contain the only important changes to navbar.html in this PR. The rest is fixing indentation, which the GitHub PR diff engine mangled.

@willihay
Fix attribute bug in updateSelectElement function
12b2c45 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
@willihay
Add comments to sass
e2b46e1 
Signed-off-by: Willow Hayward <17654918+willihay@users.noreply.github.com>
AMZN-daimini
AMZN-daimini approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@AMZN-daimini AMZN-daimini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor adjustments I can suggest is using a different background color for the banner, since hyperlinks color tends to blend a bit and makes them hard to read
image

@willihay
Copy link
Contributor Author

Only minor adjustments I can suggest is using a different background color for the banner, since hyperlinks color tends to blend a bit and makes them hard to read image

Good feedback. Yeah, I'm going to get a UX review on all the styling choices here, including this one.

@FiniteStateGit FiniteStateGit merged commit 828ce53 into o3de:main Nov 23, 2022
@FiniteStateGit FiniteStateGit deleted the willihay/website-versioning branch November 23, 2022 02:59
@willihay willihay mentioned this pull request Feb 15, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMZN-daimini AMZN-daimini AMZN-daimini approved these changes

@FiniteStateGit FiniteStateGit FiniteStateGit approved these changes

@sptramer sptramer Awaiting requested review from sptramer

@chanmosq chanmosq Awaiting requested review from chanmosq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willihay @FiniteStateGit @AMZN-daimini