-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring ROS 2 Gem docs #2266
Conversation
content/docs/user-guide/gems/reference/ros2/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/gems/reference/ros2/vehicle-dynamics.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/creating-robotic-simulation.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/project-configuration.md
Outdated
Show resolved
Hide resolved
@adamdbrw I've left some comments on the files. Here are some other changes to make:
|
The DCO issue seems to point to 777ef82, a commit on this branch. I talked about this with @michalpelka as well and we've resolve the issue so this shouldn't happen anymore. In case this happens again for another team member, to summarize, the issue is because of different name and email configurations. The Git's web interface profile configuration is set to |
79eb9b0
to
06dab7e
Compare
All comments should be applied now. I think that the DCO issue resolved itself due to rebase (the culprit commit is actually not from the branch and the issue was resolved in upstream development). @chanmosq I also un-drafted the PR. @michalpelka could you review it as well and see if it works for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates look great to me, awesome work @adamdbrw 🥳
content/docs/user-guide/interactivity/robotics/creating-robotic-simulation.md
Outdated
Show resolved
Hide resolved
Remove approval for change to be made, but didn't request changes to avoid blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at my comments and suggestions
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/vehicle-dynamics.md
Outdated
Show resolved
Hide resolved
@chanmosq is there anything else we could do to proceed with the merge of this PR? |
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/creating-robotic-simulation.md
Show resolved
Hide resolved
content/docs/user-guide/interactivity/robotics/concepts-and-components-overview.md
Show resolved
Hide resolved
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Co-authored-by: Wojtek <125894910+wojtek-robotecai@users.noreply.github.com> Signed-off-by: Michał Pełka <michalpelka@gmail.com>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> Co-authored by: Channele Mosquera <chanmosq@amazon.com>
e9a9d91
to
47fca24
Compare
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
@chanmosq I applied all the comments. I made some minor changes to reflect semantics. |
Looks great! Thanks @adamdbrw @michalpelka and @wojtek-robotecai |
Change summary
Improving structure and information efficiency of ROS 2 Gem documentation.
This is a DRAFT. Description of changes will be updated.
Submission Checklist: