Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated project manager source code map to include data classes and settings #2304

Merged
merged 3 commits into from
Mar 16, 2023
Merged

updated project manager source code map to include data classes and settings #2304

merged 3 commits into from
Mar 16, 2023

Conversation

tkothadev
Copy link
Contributor

Change summary

I have included a new section for the Project Manager detailing the data classes present in the codebase, as well as the Settings and SettingsInterface classes. This required some top level restructuring for the table of contents, to address different sections.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

updated project manager source code map to include data classes and s…
1405ed0 
…ettings.

Signed-off-by: TJ Kotha <tankotha@amazon.com>
@tkothadev tkothadev requested a review from a team as a code owner March 8, 2023 19:11
added @willihay's suggestions for reorganizing the source code map in…
d26dd48 
…to sub-pages

Signed-off-by: TJ Kotha <tankotha@amazon.com>
@tkothadev tkothadev requested a review from a team as a code owner March 16, 2023 03:38
@tkothadev tkothadev requested a review from willihay March 16, 2023 03:38
willihay
willihay approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@willihay willihay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few feedback suggestions for you to consider.

content/docs/engine-dev/tools/project-manager/source-code-map/data-classes.md Show resolved Hide resolved
content/docs/engine-dev/tools/project-manager/source-code-map/startup-and-screen-management.md Show resolved Hide resolved
addressing minor feedback for source code map
4a3543a 
Signed-off-by: TJ Kotha <tankotha@amazon.com>
@willihay willihay added this pull request to the merge queue Mar 16, 2023
Merged via the queue into o3de:development with commit 0fabd9e Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonade-dm lemonade-dm lemonade-dm approved these changes

@AMZN-alexpete AMZN-alexpete AMZN-alexpete approved these changes

@willihay willihay willihay approved these changes

@cgalvan cgalvan cgalvan approved these changes

@AMZN-Phil AMZN-Phil Awaiting requested review from AMZN-Phil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tkothadev @cgalvan @willihay @AMZN-alexpete @lemonade-dm