don't update waf version if it dosn't exist (DataDog#4801)

o5r · Oct 18, 2024 · 5e4900d · 5e4900d
1 parent 4f62b5a
commit 5e4900d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/dd-trace/src/appsec/waf/waf_manager.js b/packages/dd-trace/src/appsec/waf/waf_manager.js
@@ -51,7 +51,9 @@ class WAFManager {
   update (newRules) {
     this.ddwaf.update(newRules)
 
-    this.rulesVersion = this.ddwaf.diagnostics.ruleset_version
+    if (this.ddwaf.diagnostics.ruleset_version) {
+      this.rulesVersion = this.ddwaf.diagnostics.ruleset_version
+    }
 
     Reporter.reportWafUpdate(this.ddwafVersion, this.rulesVersion)
   }

diff --git a/packages/dd-trace/test/appsec/waf/index.spec.js b/packages/dd-trace/test/appsec/waf/index.spec.js
@@ -181,6 +181,7 @@ describe('WAF Manager', () => {
       waf.update(rules)
 
       expect(DDWAF.prototype.update).to.be.calledOnceWithExactly(rules)
+      expect(Reporter.reportWafUpdate).to.be.calledOnceWithExactly(wafVersion, '1.0.0')
     })
 
     it('should call Reporter.reportWafUpdate', () => {