-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion of Material AO (Derived from normal map) and reorganization of bakers UI to match substance designer for better UX #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to update for blender 4.2
… blur the normal map input
… multiple channels
…Constant instead of removing the if statement
…sion Eevee function
…ing function to update for blender 4.2" This reverts commit 8755782.
…sing function to update for blender 4.2" This reverts commit 6e884d2.
…ing function to update for blender 4.2" This reverts commit 8755782.
This reverts commit 6c7c664.
This reverts commit d0e4a70.
This reverts commit 0550077.
This reverts commit fd3af26.
…sing function to update for blender 4.2" This reverts commit c0a7dcb.
This reverts commit 6c7c664.
…er the direction between each format)
oRazeD
requested changes
Jul 22, 2024
utils/baker.py
Outdated
@@ -15,6 +15,13 @@ | |||
from .render import set_guide_height, get_rendered_objects | |||
from .scene import scene_setup | |||
|
|||
def BlenderVersionEevee ()-> str: | |||
#print (str(bpy.app.version)) | |||
if bpy.app.version > (4, 1, 0) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would work better as if bpy.app.version >= (4, 2, 0):
. How the code is currently written would cause an error with Blender 4.1.1+. Also remove any unnecessary print statements.
oRazeD
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also includes fixing edge case for missing file on deletion