Missing restore task file and vars file #180
Conversation
when running restore flow we failed with the following error:
TASK [ovirt.ovirt.engine_setup : Restore engine from file] *********************
fatal: [example.com]: FAILED! => {"reason": "Could not find or access
'/path/to/file/restore_engine_from_file.yml' on the Ansible Controller."}
There was a problem hiding this comment.
We do not use the restore in hosted-engine (we have there our own code for that. Perhaps worth considering merging, not that important right now), so I do not know current code well. It looks ok (other than engine-cleanup). I assume it was a simple omission when copying it from ovirt-ansible-engine-setup. Did you check the current diff between them? There are a few other things not copied - perhaps none are important, but better make sure - things around tests, meta, requirements, etc.
| @@ -0,0 +1,19 @@ | |||
| --- | |||
| - name: Run engine cleanup command | |||
| command: "engine-cleanup" | |||
There was a problem hiding this comment.
Without an answerfile? It would get stuck asking questions. Was this ever tested?
Perhaps also add 'ignore_errors: true'.
There was a problem hiding this comment.
yes you right!!
we have an open issue about it in:
https://github.com/oVirt/ovirt-ansible-engine-setup/issues/93
There was a problem hiding this comment.
I'll move the issue to the collection so we have everything here. (Please let me know if I missed some important issue which should be moved here)
|
The content of this PR merged in: |
|
Fine for me to merge current, if you also keep tracking open issues in the old project (or copy them here). |
when running restore flow we failed with the following error:
TASK [ovirt.ovirt.engine_setup : Restore engine from file] *********************
fatal: [example.com]: FAILED! => {"reason": "Could not find or access
'/path/to/file/restore_engine_from_file.yml' on the Ansible Controller."}