ovirt_disk: automatically detect virtual size of qcow image #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci test please |
mwperina
reviewed
Nov 20, 2020
|
ci test please |
1 similar comment
|
ci test please |
nirs
reviewed
Dec 7, 2020
barpavel
reviewed
Dec 7, 2020
| self._module.params['upload_image_path'] | ||
| ]) | ||
| measure = json.loads(out) | ||
| disk.initial_size = measure["required"] |
There was a problem hiding this comment.
measure["required"] is not a boolean value?
disk.initial_size shouldn't be a number?
There was a problem hiding this comment.
Did you try to run qemu-img measure? It will answer your question.
There was a problem hiding this comment.
OK. No issues :)
The JSON output is an object of QAPI type BlockMeasureInfo
Fields
fully_allocated: isize
required: isize
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1883949