Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

role: hosted_engine_setup: Filter VLAN devices with bad names #238

Merged
merged 4 commits into from
Jun 15, 2021
Merged

role: hosted_engine_setup: Filter VLAN devices with bad names #238

merged 4 commits into from
Jun 15, 2021

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Mar 21, 2021

Filter VLAN devices with bad names

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1933642
Signed-off-by: Aviv Turgeman aturgema@redhat.com

@avivtur
Copy link
Contributor Author

avivtur commented Mar 21, 2021

Verified

@avivtur avivtur force-pushed the bz_1858325 branch 2 times, most recently from 5c24bb0 to 8ab65d5 Compare March 21, 2021 12:29
@mnecas mnecas requested a review from arachmani March 22, 2021 10:37
@sandrobonazzola sandrobonazzola requested a review from mnecas March 25, 2021 08:18
arachmani
arachmani reviewed Apr 5, 2021
View reviewed changes
Copy link
Member

@arachmani arachmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we added the team filtering we had a message only for team devices that were not supported, now we have further options, so I think it's best if we add also a fail message for each unsupported case when only this type is available.

roles/hosted_engine_setup/tasks/filter_unsupported_vlan_devices.yml Outdated Show resolved Hide resolved
roles/hosted_engine_setup/tasks/filter_unsupported_devices.yml Outdated Show resolved Hide resolved
@avivtur
Copy link
Contributor Author

avivtur commented Apr 25, 2021

Verified
Followed @arachmani comments

@avivtur avivtur force-pushed the bz_1858325 branch 2 times, most recently from 69d2503 to 147eb42 Compare April 26, 2021 10:31
@arachmani arachmani changed the title role: hosted_engine_setup role: hosted_engine_setup: Filter VLAN devices with bad names Jun 1, 2021
@avivtur avivtur force-pushed the bz_1858325 branch 6 times, most recently from ee0fc8a to bc82761 Compare June 9, 2021 07:53
@avivtur
Copy link
Contributor Author

avivtur commented Jun 9, 2021

ci test please

mnecas
mnecas requested changes Jun 9, 2021
View reviewed changes
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all debug modules or add to all of them name. CI currently does not check this but we are moving to ansible-lint 5.0.0 where it is required.

roles/hosted_engine_setup/tasks/filter_team_devices.yml Outdated Show resolved Hide resolved
@avivtur avivtur force-pushed the bz_1858325 branch 3 times, most recently from 48eadb9 to 86c438f Compare June 9, 2021 11:31
@avivtur
role: hosted_engine_setup
e90fff6 
Filter VLAN devices with bad names

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1933642
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur requested a review from mnecas June 14, 2021 17:30
mnecas
mnecas approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas requested a review from arachmani June 15, 2021 09:39
@mnecas mnecas merged commit b9eb218 into oVirt:master Jun 15, 2021
vjuranek pushed a commit to vjuranek/ovirt-ansible-collection that referenced this pull request Jul 28, 2021
@avivtur @mnecas @vjuranek
role: hosted_engine_setup: Filter VLAN devices with bad names (oVirt#238
0317822 
)

* role: hosted_engine_setup

Filter VLAN devices with bad names

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1933642
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>

* Update hosted_engine_setup-ansible-lint-5.0.0-alignment

* Create 23-filter-VLAN-devices-with-bad-names.yml

* Rename 23-filter-VLAN-devices-with-bad-names.yml to 238-filter-vlan-devices-with-bad-names.yml

Co-authored-by: Martin Nečas <necas.marty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arachmani arachmani arachmani approved these changes

@mnecas mnecas mnecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avivtur @mnecas @arachmani