roles: hosted_engine_setup: replace virt_net and xml with commands #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnecas
requested review from
sandrobonazzola,
didib,
michalskrivanek and
arachmani
mnecas
force-pushed
the
add_xml_filter
branch
from
70b57ca to
aea02b0
Compare
|
lgtm (if it works) |
|
AFAICT looks good |
arachmani
reviewed
Oct 14, 2021
|
ci test please |
|
ci test please |
arachmani
requested changes
Dec 9, 2021
There was a problem hiding this comment.
Tried to verify, on a none-clean host (host that runs a failed/successful deployment) after using ovirt-hosted-engine-cleanup the deployment failed with the following error:
[ INFO ] changed: [localhost]
[ INFO ] TASK [ovirt.ovirt.hosted_engine_setup : Update libvirt default network configuration, destroy]
[ ERROR ] fatal: [localhost]: FAILED! => {"changed": false, "cmd": ["virsh", "net-destroy", "default"], "delta": "0:00:00.026791", "end": "2021-12-08 15:10:11.206631", "msg": "non-zero return code", "rc": 1, "start": "2021-12-08 15:10:11.179840", "stderr": "error: Failed to destroy network default\nerror: Requested operation is not valid: network 'default' is not active", "stderr_lines": ["error: Failed to destroy network default", "error: Requested operation is not valid: network 'default' is not active"], "stdout": "", "stdout_lines": []}
[ ERROR ] Failed to execute stage 'Closing up': Failed getting local_vm_dir
Networks list before the deployment:
# virsh -r net-list --all
Name State Autostart Persistent
------------------------------------------------
;vdsmdummy; active no no
|
Added the ignore_errors to the net-destroy think it should resolve the issue. |
arachmani
changed the title
arachmani
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to replace all community modules because ansible-core 2.11 does not include any community modules.
New filter:
This patch adds
get_bridge_xml_to_dictwhich converts stdout fromvirsh net-dumpxml defaultto the dictionary which has all bridge information. Later it is passed to the new template and used to configure the network bridge.New template:
network-config.j2contains the jinja template from which the XML network configuration will be created.Now users can specify both
he_ipv6_subnet_prefixandhe_ipv4_subnet_prefixand will support both modes before users could specify only one mode.