roles: hosted_engine_setup: Adjust files permissions #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
approved these changes
Dec 16, 2021
|
I personally think that 0770/0660 are mandatory, and if they do not work, we should find out why and fix that. The image includes sensitive stuff (hashed root password) and might include other sensitive stuff from user customization. |
didib
suggested changes
Dec 16, 2021
roles/hosted_engine_setup/tasks/bootstrap_local_vm/02_create_local_vm.yml
Outdated
Show resolved
Hide resolved
roles/hosted_engine_setup/tasks/bootstrap_local_vm/02_create_local_vm.yml
Outdated
Show resolved
Hide resolved
roles/hosted_engine_setup/tasks/bootstrap_local_vm/02_create_local_vm.yml
Outdated
Show resolved
Hide resolved
roles/hosted_engine_setup/tasks/create_target_vm/03_hosted_engine_final_tasks.yml
Outdated
Show resolved
Hide resolved
|
Verified and opened https://bugzilla.redhat.com/show_bug.cgi?id=2035631 |
Adjusting files permissions for supporting umask 077 Bug-Url: https://bugzilla.redhat.com/2020620 Signed-off-by: Asaf Rachmani <arachman@redhat.com>
didib
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting files permissions for supporting umask 077.
For security purposes we decided to use 770/660 permissions for the localvm directory, this directory contains the appliance image, and for creating the engine VM we must have its user/group configured for
qemu, otherwiseqemuuser won't have search permissions for the appliance image (see also https://libvirt.org/drvqemu.html#posix-users-groups).Therefore we have decided to use
qemugroup instead ofkvm.Bug-Url: https://bugzilla.redhat.com/2020620
Signed-off-by: Asaf Rachmani arachman@redhat.com