roles: hosted_engine_setup: Adding the -n flag to qemu-img command #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code LGTM, please add a changelog and a commit message with "Signed-off-by" in order to make CI happy. |
arachmani
changed the title
saksham-oracle
force-pushed
the
qemu-img-change
branch
from
b239709 to
429837d
Compare
|
+1 |
saksham-oracle
force-pushed
the
qemu-img-change
branch
2 times, most recently
from
c304fc3 to
557b030
Compare
1. Desired Engine Disk size for hosted engine VM is not reflected and always 38GB. Fix: 1. Adding the -n flag to use the same flags used by vdsm to ensure that we get consistent results compatible with volumes created by vdsm. Vdsm now uses -n flag for all qemu-img convert calls "https://gerrit.ovirt.org/c/vdsm/+/109784". https://bugzilla.redhat.com/show_bug.cgi?id=1828888#c5 Signed-off-by: Saksham Srivastava <saksham.sa.srivastava@oracle.com>
saksham-oracle
force-pushed
the
qemu-img-change
branch
from
557b030 to
b69abce
Compare
mnecas
approved these changes
Feb 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fix:
https://bugzilla.redhat.com/show_bug.cgi?id=1828888#c5
Signed-off-by: Saksham Srivastava saksham.sa.srivastava@oracle.com