Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DC/cluster level 4.8 and qcow2 discard-no-unref flag #938

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Add support for DC/cluster level 4.8 and qcow2 discard-no-unref flag #938

merged 3 commits into from
Jun 7, 2024

Commits on Jun 6, 2024

  1. Add support for DC/cluster level 4.8 

    This patch adds support for DC/cluster compatibility level 4.8. Hosts need to be running on libvirt >= 9.5 and qemu-kvm 8.1.

Signed-off-by: Brooklyn Dewolf <contact@brooklyn.gent>
    @BrooklynDewolf @sandrobonazzola
    BrooklynDewolf authored and sandrobonazzola committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0f6a001 View commit details
    Browse the repository at this point in the history

  2. Added discard-no-unref support to CL 4.8 

    The discard-no-unref was introduced to qemu to counteract fragmentation. Without this, qcow2 images would grow over 100% of their size. See https://patchew.org/QEMU/20230602124747.1544077-1-jean-louis@dupond.be/

I have added the option to ovirt-engine so that this flag is enabled by default on hosts with cluster level compatibility level 4.8. The EnableQemuDiscardNoUnref option can be enabled/disabled in the config. The Virtual Disk option 'Enable Discard' also needs to be active before this flag is enabled.

Signed-off-by: Brooklyn Dewolf <contact@brooklyn.gent>
    @BrooklynDewolf @sandrobonazzola
    BrooklynDewolf authored and sandrobonazzola committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ab41880 View commit details
    Browse the repository at this point in the history

  3. Bump machine type for cluster level 4.8 

    Hosts supporting level 4.8 need to be running on RHEL 9.4 or CentOS Stream/RHEL 9.

Signed-off-by: Brooklyn Dewolf <contact@brooklyn.gent>
    @BrooklynDewolf @sandrobonazzola
    BrooklynDewolf authored and sandrobonazzola committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    574f3ce View commit details
    Browse the repository at this point in the history