-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ticket id with transfer id in logs #26
Comments
nirs
added a commit
to nirs/ovirt-imageio
that referenced
this issue
Jan 21, 2022
Use the public transfer id instead of the sensitive ticket id used for authentication. This makes it easier to follow transfer by grepping the transfer id. The ticket id is till logged when adding a ticket, we may want to remove it from the log, or log only a part of the ticket. Fixes oVirt#26 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ovirt-imageio
that referenced
this issue
Jan 21, 2022
Use the public transfer id instead of the sensitive ticket id used for authentication. This makes it easier to follow transfer by grepping the transfer id. The ticket id is till logged when adding a ticket, we may want to remove it from the log, or log only a part of the ticket. Fixes oVirt#26 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
vjuranek
pushed a commit
that referenced
this issue
Jan 24, 2022
Use the public transfer id instead of the sensitive ticket id used for authentication. This makes it easier to follow transfer by grepping the transfer id. The ticket id is till logged when adding a ticket, we may want to remove it from the log, or log only a part of the ticket. Fixes #26 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following bug https://bugzilla.redhat.com/2043283, imageio log the ticket id
for tracking requests. This is wrong since the ticket id is sensitive information
and the way we track image transfers in all other components is using the transfer
id.
Here example logs using the ticket id:
(Logs fixed by https://bugzilla.redhat.com/2043283 were removed)
I'm not sure if we should remove the ticket id from the ADD log, this need
more thinking. But for the rest of the logs, there is really no need to
show ticket=, and we can simplify replace it with transfer=.
The text was updated successfully, but these errors were encountered: