Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Don't track ranges for read-write ticket #32

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

nirs
Copy link
Member

@nirs nirs commented Feb 8, 2022

When using read-write ticket, we don't report the number of transferred
bytes, so there is no point to track the ranges.

This is so far the biggest optimization, lowering the overhead per
request by 20%. However since engine never use read-write mode, this
does not improve real flows.

The most important benefit is proving that additional optimization in
measuring ranges is not effective, since 80% of the time is spent
elsewhere.

test_run_benchmark[ro-nbdcopy-1] 1 workers, 25600 ops, 1.884 s, 13588.32 ops/s
test_run_benchmark[ro-nbdcopy-2] 2 workers, 25600 ops, 2.229 s, 11483.24 ops/s
test_run_benchmark[ro-nbdcopy-4] 4 workers, 25600 ops, 2.305 s, 11104.09 ops/s
test_run_benchmark[ro-nbdcopy-8] 8 workers, 25600 ops, 2.410 s, 10623.58 ops/s
test_run_benchmark[ro-imageio-1] 1 workers, 25600 ops, 1.896 s, 13505.05 ops/s
test_run_benchmark[ro-imageio-2] 2 workers, 25600 ops, 2.270 s, 11275.83 ops/s
test_run_benchmark[ro-imageio-4] 4 workers, 25600 ops, 2.269 s, 11280.55 ops/s
test_run_benchmark[ro-imageio-8] 8 workers, 25600 ops, 2.361 s, 10841.85 ops/s
test_run_benchmark[rw-nbdcopy-1] 1 workers, 25600 ops, 1.786 s, 14332.42 ops/s
test_run_benchmark[rw-nbdcopy-2] 2 workers, 25600 ops, 2.188 s, 11700.01 ops/s
test_run_benchmark[rw-nbdcopy-4] 4 workers, 25600 ops, 2.098 s, 12204.83 ops/s
test_run_benchmark[rw-nbdcopy-8] 8 workers, 25600 ops, 1.932 s, 13247.69 ops/s
test_run_benchmark[rw-imageio-1] 1 workers, 25600 ops, 1.719 s, 14895.74 ops/s
test_run_benchmark[rw-imageio-2] 2 workers, 25600 ops, 2.353 s, 10881.34 ops/s
test_run_benchmark[rw-imageio-4] 4 workers, 25600 ops, 2.192 s, 11679.60 ops/s
test_run_benchmark[rw-imageio-8] 8 workers, 25600 ops, 2.192 s, 11677.66 ops/s

Signed-off-by: Nir Soffer nsoffer@redhat.com

When using read-write ticket, we don't report the number of transferred
bytes, so there is no point to track the ranges.

This is so far the biggest optimization, lowering the overhead per
request by 20%. However since engine never use read-write mode, this
does not improve real flows.

The most important benefit is proving that additional optimization in
measuring ranges is not effective, since 80% of the time is spent
elsewhere.

test_run_benchmark[ro-nbdcopy-1] 1 workers, 25600 ops, 1.884 s, 13588.32 ops/s
test_run_benchmark[ro-nbdcopy-2] 2 workers, 25600 ops, 2.229 s, 11483.24 ops/s
test_run_benchmark[ro-nbdcopy-4] 4 workers, 25600 ops, 2.305 s, 11104.09 ops/s
test_run_benchmark[ro-nbdcopy-8] 8 workers, 25600 ops, 2.410 s, 10623.58 ops/s
test_run_benchmark[ro-imageio-1] 1 workers, 25600 ops, 1.896 s, 13505.05 ops/s
test_run_benchmark[ro-imageio-2] 2 workers, 25600 ops, 2.270 s, 11275.83 ops/s
test_run_benchmark[ro-imageio-4] 4 workers, 25600 ops, 2.269 s, 11280.55 ops/s
test_run_benchmark[ro-imageio-8] 8 workers, 25600 ops, 2.361 s, 10841.85 ops/s
test_run_benchmark[rw-nbdcopy-1] 1 workers, 25600 ops, 1.786 s, 14332.42 ops/s
test_run_benchmark[rw-nbdcopy-2] 2 workers, 25600 ops, 2.188 s, 11700.01 ops/s
test_run_benchmark[rw-nbdcopy-4] 4 workers, 25600 ops, 2.098 s, 12204.83 ops/s
test_run_benchmark[rw-nbdcopy-8] 8 workers, 25600 ops, 1.932 s, 13247.69 ops/s
test_run_benchmark[rw-imageio-1] 1 workers, 25600 ops, 1.719 s, 14895.74 ops/s
test_run_benchmark[rw-imageio-2] 2 workers, 25600 ops, 2.353 s, 10881.34 ops/s
test_run_benchmark[rw-imageio-4] 4 workers, 25600 ops, 2.192 s, 11679.60 ops/s
test_run_benchmark[rw-imageio-8] 8 workers, 25600 ops, 2.192 s, 11677.66 ops/s

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs requested review from vjuranek and bennyz February 8, 2022 19:30
@vjuranek vjuranek merged commit cc62116 into oVirt:master Feb 9, 2022
@nirs nirs deleted the auth-rw branch March 27, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants