Nmstate for bridge options #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the package available everywhere? And also this patch should make |
Require nmstate > 1.2.1-3 that supports bridge options so that their handling can be removed from vdsm. Change-Id: I1ca9070f4b52450ecb3fbbb51c117ad4a59e476c Signed-off-by: Eitan Raviv <eraviv@redhat.com>
the bridge options are currently implemented via sysfs, We want to use nmstate for bridge options.
Multicast-router is understood by nmstate and therefore can be used in bridge-opts in tests. Change-Id: Iba9445eabf74037396308e1088a805c927f8f83e Signed-off-by: Eitan Raviv <eraviv@redhat.com>
erav
force-pushed
the
nmstate-for-bridge-options
branch
from
89f1b1b to
c5cc872
Compare
|
passed on network suite el8stream run #42262 with nmstate-1.3.0-1.el8.x86_64 |
|
passed on network suite rhel8 run #42286 with nmstate-1.2.1-3.el8_6.x86_64 |
|
passed on basic suite rhel8 run #42297 with nmstate-1.2.1-3.el8_6.x86_64 |
almusil
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of PR #118