Add Link component #209
Add Link component #209
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oacore/design/7kuh43me2 |
|
@viktor-yakubiv Don't you know by any chance the name of the external icon? It's like finding a needle in the haystack. |
|
If I remember, |
The backside of the fancy markdown 😄 |
|
I am looking into it. I will send an update, I am exploring more cases. However, I like the overlall result. Thanks a lot for doing this 👍 |
|
I found the icon looks good in Safari but in Chrome and Firefox it does not look very good in text. Feel free to check it now but I will apply some changes. By the way, I do not recommend to change the default display for the text elements, it may be unexpected for the user. |
|
There is a problem that I see can only be solved with web-fonts at the moment (without JS processing). I wish I am wrong and there is an option with the background + mask bit obviously inline-block behaves like an image too.
The icon should break with the last work within the link alway. |
|
I added a simple solution but we should investigate this breaking rules more because it will become a headache when goes to production. |
Adds a wrapper around the HTML Anchor Element (<a>) to simplify working with the external links. The component fixes the recommendation to pass `rel="noopener noreferrer"` on its level. Includes `open-in-new` icon into the design.config. Co-authored-by: Viktor Yakubiv <viktor@yakubiv.com>
If the users click on Link in the menu they were redirected to the Button Link subsection instead because it has the same autogenerated ID. To avoid such problems we should try to keep all headings and subheading different within all the files. Despite it's better to find another solution.
|
@Joozty sorry I put my hands here maybe too much. I tried to explain my concerns as much as possible and even created an issue after this (#216). I wonder if you have any comments but if you don't feel free to rebase and merge 😉 Thanks a lot for looking into this. It was interesting investigation, I hope for both of us 🙂 |
You would need another wrapper I guess. Anyway thanks for looking into this. As I always say I don't see any difference whether the element is inline flex or just inline. 😄 |
Adds a wrapper around the HTML Anchor Element (<a>) to simplify working with the external links. The component fixes the recommendation to pass `rel="noopener noreferrer"` on its level. Includes `open-in-new` icon into the design.config. Co-authored-by: Viktor Yakubiv <viktor@yakubiv.com>
|
This is exactly the solution I was thinking about but it needs language processing on JS what I would like to avoid. I would rather have this defect than handle it in such way. |
Closes #205