Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modal #321

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Add Modal #321

merged 1 commit into from
Sep 14, 2020

Conversation

Joozty
Copy link
Member

@Joozty Joozty commented Sep 10, 2020

No description provided.

@vercel
Copy link

vercel bot commented Sep 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oacore/design/jx1xp4bno
✅ Preview: https://design-git-modal.oacore.vercel.app

@Joozty
Copy link
Member Author

Joozty commented Sep 10, 2020

@viktor-yakubiv what do you think? Do we need anything else? (closable icon in the right top corner, animations...)

@Joozty Joozty marked this pull request as ready for review September 10, 2020 12:26
@viktor-yakubiv
Copy link
Member

It's too wide to my eye but works nice

@Joozty
Copy link
Member Author

Joozty commented Sep 14, 2020

I agree especially if the terms and conditions have 80characters per line. Let me change that.

Copy link
Member

@viktor-yakubiv viktor-yakubiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done very well. It makes me think about a few things related to the usage of the popup.

Perhaps modals must be auto-closable with 'Escape' always with automatic choosing less dangerous action, e.g. 'cancel' or 'no', and should not be used where such an action cannot be chosen.

Also, the mobile view and behaviour are not obvious to me.

However, I don't mind shipping this as the first iteration.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/modules/modal/content.jsx Show resolved Hide resolved
src/modules/modal/modal.jsx Outdated Show resolved Hide resolved
src/modules/modal/portal.jsx Show resolved Hide resolved
src/modules/modal/modal.jsx Outdated Show resolved Hide resolved
src/modules/modal/modal.jsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants