Updated MemoryGenericRepository to use a ConcurrentDictionary #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You changed the whole file, maybe line endings problem? |
|
Maybe. For my own part I changed a couple of lines of code in the MemoryGenericRepository.cs file; nothing more. If VS2019 did something wacky I’m sorry…
From: Diogo Neves <notifications@github.com>
Sent: Friday, July 24, 2020 4:59 PM
To: oakcool/OakIdeas.GenericRepository <OakIdeas.GenericRepository@noreply.github.com>
Cc: Louis S. Berman <louis@squideyes.com>; Author <author@noreply.github.com>
Subject: Re: [oakcool/OakIdeas.GenericRepository] Updated MemoryGenericRepository to use a ConcurrentDictionary (#1)
You changed the whole file, maybe line endings problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABACOHFFV4WNMSIWTU5XPELR5HYXNANCNFSM4PHARJEQ>.
|
|
This is a great idea, would you mind undoing the changes and then just pushing the actually changes again. Thanks a lot for contributing, and sorry for the very late response. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sharing. I made a small change (swapped out the Dictionary in MemoryGenericRepository for a ConcurrentDictionary) to allow the library to work better in multithreading scenarios.