change trait name from CamelCase to snake_case #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rudr the trait names are all in snake_case due to k8s naming restrictions. To make the spec clear and consistent to users, we'd better fix all trait names to be snake_case.
hongchaodeng
requested review from
resouer,
technosophos and
vturecek
as code owners
resouer
reviewed
Jan 16, 2020
resouer
reviewed
Jan 16, 2020
wonderflow
approved these changes
Jan 16, 2020
|
Addressed comments |
|
Also fix the inconsistency in Rudr: oam-dev/rudr#516 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #299
In Rudr the trait names are all in snake_case due to k8s naming restrictions.
To make the spec clear and consistent to users, we'd better fix all trait names to be snake_case.