Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1372] Change ignore to disregard in messages #1046

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

pr-watson
Copy link
Contributor

Some of our remediation messages have used 'ignore' to tell the user they can override certain checks, example - "If you wish to ignore this message, set the environment variable 'CONVERT2RHEL_OUTDATED_PACKAGE_CHECK_SKIP' to 1". Using the word 'disregard' sounds better in this context so each instance of that has been changed.

Jira Issues: RHELC-1372

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@pr-watson pr-watson added kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Jan 24, 2024
@has-bot
Copy link
Member

has-bot commented Jan 24, 2024

/packit test --labels sanity


@oamg/conversions-qe please review results and provide ack.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b1ae12) 94.33% compared to head (bb892d7) 94.33%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          47       47           
  Lines        4552     4552           
  Branches      811      811           
=======================================
  Hits         4294     4294           
  Misses        182      182           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 89.51% <ø> (ø)
centos-linux-8 90.51% <ø> (ø)
centos-linux-9 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Venefilyn Venefilyn added tests/skip This PR does not require integration tests to be run. and removed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Jan 25, 2024
@has-bot
Copy link
Member

has-bot commented Jan 25, 2024

This PR does not require integration tests to be run.


@oamg/conversions-qe please review results and provide ack.

@Venefilyn Venefilyn merged commit d21ec6f into oamg:main Jan 25, 2024
29 of 69 checks passed
@Venefilyn Venefilyn changed the title [RHELC-1372] Change ignore to disregard in messages [RHELC-1372] Change ignore to disregard in messages Jan 25, 2024
@Venefilyn Venefilyn mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants