[RHELC-1425] Remove deprecated CLI arguments #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
added
kind/breaking
Venefilyn
force-pushed
the
chore/remove-deprecated-cli-args
branch
2 times, most recently
from
013397c
to
dc7d451
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
- Coverage 95.38% 95.37% -0.02%
==========================================
Files 51 51
Lines 4616 4603 -13
Branches 817 813 -4
==========================================
- Hits 4403 4390 -13
Misses 137 137
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/packit test --labels sanity |
bookwar
changed the title
r0x0d
reviewed
Mar 4, 2024
hosekadam
reviewed
Mar 5, 2024
convert2rhel/toolopts.py
Outdated
| # corner case: password on CLI or in password file and activation-key in the config file | ||
| # password from CLI has precedence and activation-key must be deleted (unused) |
There was a problem hiding this comment.
Suggested change
| # corner case: password on CLI or in password file and activation-key in the config file | |
| # password from CLI has precedence and activation-key must be deleted (unused) | |
| # corner case: password on CLI and activation-key in the config file | |
| # password from CLI has precedence and activation-key must be deleted (unused) |
Venefilyn
force-pushed
the
chore/remove-deprecated-cli-args
branch
from
dc7d451
to
c922249
Compare
hosekadam
reviewed
Mar 6, 2024
Venefilyn
force-pushed
the
chore/remove-deprecated-cli-args
branch
2 times, most recently
from
e7667a3
to
d79b63a
Compare
|
/packit test --labels sanity |
hosekadam
reviewed
Mar 6, 2024
scripts/manpage_generation.sh
Outdated
There was a problem hiding this comment.
I'm just wondering if those changes are related to this PR or those are some forgotten changes from something different.
There was a problem hiding this comment.
Ah you're right! While generating locally I had to change it. Will fix
Venefilyn
force-pushed
the
chore/remove-deprecated-cli-args
branch
from
d79b63a
to
a571818
Compare
This removes a few deprecated CLI arguments, they will no longer work or give a warning about its deprecation. This includes - Removal of `convert2rhel -f|--password-from-file` - Removal of unused `convert2rhel --keep-rhsm`
Venefilyn
force-pushed
the
chore/remove-deprecated-cli-args
branch
from
a571818
to
57818d8
Compare
hosekadam
approved these changes
Mar 12, 2024
Merged
hosekadam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a few deprecated CLI arguments, they will no longer work
or give a warning about its deprecation.
This includes
convert2rhel -f|--password-from-fileconvert2rhel --keep-rhsmJira Issues: RHELC-1425
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant