[RHELC-1396] fix: errors in utils.py after full test suite #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
changed the title
Since of merging oamg#1029 we get an issue with unit tests that causes a lot of strange errors to occur. Likely due to a stream not being closed correctly. This aims to either fix or mitigate this from occuring during test runs as it should not appear in convert2rhel by itself.
Venefilyn
force-pushed
the
fix/logging-errors
branch
from
4eb57a8
to
6e94925
Compare
Venefilyn
changed the title
Venefilyn
added
skip/changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 51 51
Lines 4627 4627
Branches 820 820
=======================================
Hits 4418 4418
Misses 134 134
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since of merging #1029 we get an issue with unit tests that causes a lot
of strange errors to occur. Likely due to a stream not being closed
correctly.
This aims to either fix or mitigate this from occuring during test runs
as it should not appear in convert2rhel by itself.
Jira Issues: RHELC-1396
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant