Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1520] Remove leftover reposdir from package updates action #1203

Merged
merged 1 commit into from
May 2, 2024

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Apr 30, 2024

A regression was detected in the package updates tier1 test as the pull request #1181 got merged in upstream.

This commit aims to remove the leftover reposdir from the packge updates action as the folder is empty and there is nothing backed up inside it.

Jira Issues: RHELC-1520

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

A regression was detected in the package updates tier1 test as the pull
request oamg#1181 got merged in upstream.

This commit aims to remove the leftover reposdir from the packge updates
action as the folder is empty and there is nothing backed up inside it.
@r0x0d r0x0d requested a review from kokesak April 30, 2024 12:42
@r0x0d r0x0d added tests/all Run the full test suite. Equivalent to `/packit test`. kind/bug-fix A bug has been fixed labels Apr 30, 2024
@has-bot
Copy link
Member

has-bot commented Apr 30, 2024

/packit test


Comment generated by an automation.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (3c02999) to head (b93a096).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
- Coverage   95.45%   95.44%   -0.01%     
==========================================
  Files          53       53              
  Lines        4638     4633       -5     
  Branches      812      811       -1     
==========================================
- Hits         4427     4422       -5     
  Misses        133      133              
  Partials       78       78              
Flag Coverage Δ
centos-linux-7 90.59% <100.00%> (+0.03%) ⬆️
centos-linux-8 91.52% <100.00%> (-0.01%) ⬇️
centos-linux-9 91.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokesak
Copy link
Member

kokesak commented Apr 30, 2024

/packit test

@kokesak
Copy link
Member

kokesak commented Apr 30, 2024

Seems like the fix is working:

[2024-04-30T13:26:02+0000] TASK - [Prepare: Check if the installed packages are up-to-date] **********
WARNING - The system has 1 package(s) not updated based on repositories defined in the system repositories.
List of packages to update: wpa_supplicant.

Not updating the packages may cause the conversion to fail.
Consider updating the packages before proceeding with the conversion.
ERROR - (OVERRIDABLE) PACKAGE_UPDATES::OUT_OF_DATE_PACKAGES - Outdated packages detected
 Description: Please refer to the diagnosis for further information
 Diagnosis: The system has 1 package(s) not updated based on repositories defined in the system repositories.
List of packages to update: wpa_supplicant.

The testing-farm:Rocky-8-EC2-Base-8.8-20230518.0.x86_64-x86_64:tier0-rl88 fail will be fixed in the #1192

@r0x0d r0x0d merged commit 07fbf7c into oamg:main May 2, 2024
43 of 47 checks passed
@r0x0d r0x0d deleted the fix-reposdir-in-packages-updates-actions branch May 2, 2024 12:41
@hosekadam hosekadam mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed tests/all Run the full test suite. Equivalent to `/packit test`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants