[RHELC-1337] Port kernel_boot_files to the Action framework #1301

pr-watson · 2024-07-11T20:48:51Z

This PR ports the function check_kernel_boot_files to the action framework. Changing any relevant logger crictical, warning and info messages to Error results and Warning and Info messages respectively.

Jira Issues:

RHELC-1337

Checklist

PR has been tested manually in a VM (either author or reviewer)
Jira issue has been made public if possible
[RHELC-] or [HMS-] is part of the PR title
GitHub label has been added to help with Release notes
PR title explains the change from the user's point of view
Code and tests are documented properly
The commits are squashed to as few commits as possible (without losing data)
When merged: Jira issue has been updated to Release Pending if relevant

has-bot · 2024-07-11T20:49:40Z

/packit test --labels sanity

Comment generated by an automation.

Log | Bot Usage

convert2rhel/unit_tests/actions/post_conversion/kernel_boot_files_test.py

codecov · 2024-07-11T21:08:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (46d8c79) to head (1686a0e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1301   +/-   ##
=======================================
  Coverage   96.38%   96.39%           
=======================================
  Files          63       64    +1     
  Lines        4929     4942   +13     
  Branches      864      864           
=======================================
+ Hits         4751     4764   +13     
  Misses        101      101           
  Partials       77       77

Flag	Coverage Δ
centos-linux-7	`91.77% <100.00%> (+0.02%)`	⬆️
centos-linux-8	`92.66% <100.00%> (+0.01%)`	⬆️
centos-linux-9	`92.70% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

r0x0d

Looks nice. Just a few comments.

convert2rhel/actions/post_conversion/kernel_boot_files.py

convert2rhel/unit_tests/actions/post_conversion/kernel_boot_files_test.py

convert2rhel/actions/post_conversion/kernel_boot_files.py

Venefilyn

LGTM, ideally a second person should approve as I've touched a lot of the messages here

Unit tests failing atm

convert2rhel/unit_tests/actions/post_conversion/kernel_boot_files_test.py

+import pytest
+import six
+
+from convert2rhel import actions, checks, grub


kokesak · 2024-08-15T08:54:31Z

/packit test --labels sanity

kokesak · 2024-08-15T08:55:55Z

@pr-watson once ready, please rebase on top of the master branch to have the latest tests in place

kokesak

QA ack

r0x0d · 2024-08-16T13:44:58Z

/packit test --labels sanity

convert2rhel/actions/post_conversion/kernel_boot_files.py

r0x0d · 2024-08-16T17:40:06Z

/packit test --labels sanity

hosekadam

The failure of integration tests is related to change of command rpm -Va to rpm -Va --nodeps. Just needs a rebase.

LGTM!

Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>

Co-authored-by: Freya Gustavsson <freya@spytec.se>

for more information, see https://pre-commit.ci

Co-authored-by: Adam Hošek <hosek.adam@outlook.com>

Venefilyn · 2024-08-19T11:18:43Z

/packit test --labels sanity

r0x0d · 2024-08-19T12:26:04Z

@danmyway is retriggering the failed test on tesar to discard the possibility of test regression.

danmyway · 2024-08-19T12:31:46Z

====================
AlmaLinux OS 8.10.20240530 x86_64
   tier1/destructive/kernel_boot_files
      Test results: http://artifacts.osci.redhat.com/testing-farm/44fd31dc-8b1e-47ec-85ec-3be27f3b4765
====================
Rocky-8-EC2-Base-8.10-20240528.0.x86_64
   tier1/destructive/kernel_boot_files
      Test results: http://artifacts.osci.redhat.com/testing-farm/55ba76d8-6e2c-47be-93d6-325c2164e89e
====================
OL8.9-x86_64-HVM-2024-02-02
   tier1/destructive/kernel_boot_files
      Test results: http://artifacts.osci.redhat.com/testing-farm/f2baa7cd-c32f-4c11-9ea6-143b4ac762f4
====================
OL7.9-x86_64-HVM-2023-01-05
   tier1/destructive/kernel_boot_files
      Test results: http://artifacts.osci.redhat.com/testing-farm/64aa3fe6-ccff-4efc-9c51-7b59876de774

danmyway · 2024-08-19T13:01:36Z

+--------------------------------------+-----------------------------------------+-------------------------------------------------------------------------+-----------+
| UUID                                 | Target                                  | Test Plan                                                               | Result    |
+--------------------------------------+-----------------------------------------+-------------------------------------------------------------------------+-----------+
| 44fd31dc-8b1e-47ec-85ec-3be27f3b4765 | AlmaLinux OS 8.10.20240530 x86_64       |                                                                         |           |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/corrupted_initramfs_file      | PASSED    |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/missing_initramfs_and_vmlinuz | PASSED    |
| 55ba76d8-6e2c-47be-93d6-325c2164e89e | Rocky-8-EC2-Base-8.10-20240528.0.x86_64 |                                                                         |           |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/corrupted_initramfs_file      | PASSED    |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/missing_initramfs_and_vmlinuz | PASSED    |
| f2baa7cd-c32f-4c11-9ea6-143b4ac762f4 | OL8.9-x86_64-HVM-2024-02-02             |                                                                         |           |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/corrupted_initramfs_file      | PASSED    |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/missing_initramfs_and_vmlinuz | PASSED    |
| 64aa3fe6-ccff-4efc-9c51-7b59876de774 | OL7.9-x86_64-HVM-2023-01-05             |                                                                         |           |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/corrupted_initramfs_file      | PASSED    |
|                                      |                                         | plans/tier1/destructive/kernel_boot_files/missing_initramfs_and_vmlinuz | PASSED    |
+--------------------------------------+-----------------------------------------+-------------------------------------------------------------------------+-----------+

danmyway

Looking good, merging.

pr-watson added kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Jul 11, 2024

pr-watson marked this pull request as draft July 11, 2024 20:49

github-advanced-security bot found potential problems Jul 11, 2024

View reviewed changes

convert2rhel/unit_tests/actions/post_conversion/kernel_boot_files_test.py Fixed Show resolved Hide resolved

pr-watson changed the title ~~Migrate post conversion kernel boot files~~ [RHELC-1337] ] Port kernel_boot_files to the Action framework Jul 12, 2024

r0x0d reviewed Aug 5, 2024

View reviewed changes

pr-watson marked this pull request as ready for review August 5, 2024 19:24

pr-watson force-pushed the migrate-post-conversion-kernel-boot-files branch from 439285a to 4f62109 Compare August 5, 2024 19:27

r0x0d reviewed Aug 6, 2024

View reviewed changes

convert2rhel/actions/post_conversion/kernel_boot_files.py Outdated Show resolved Hide resolved

pr-watson force-pushed the migrate-post-conversion-kernel-boot-files branch from 19d708a to 8c6b2a4 Compare August 6, 2024 14:04

pr-watson requested a review from a team as a code owner August 6, 2024 14:04

pr-watson mentioned this pull request Aug 6, 2024

Post Conversion Action Framework merge order #1331

Closed

13 tasks

pr-watson force-pushed the migrate-post-conversion-kernel-boot-files branch from 5b55ab7 to c84464b Compare August 6, 2024 16:07

Venefilyn reviewed Aug 12, 2024

View reviewed changes

convert2rhel/actions/post_conversion/kernel_boot_files.py Outdated Show resolved Hide resolved

Venefilyn approved these changes Aug 13, 2024

View reviewed changes

pr-watson requested review from bocekm, bookwar, danmyway, kokesak and SerCantus as code owners August 13, 2024 17:48

pr-watson requested a review from a team as a code owner August 14, 2024 19:40

github-advanced-security bot found potential problems Aug 14, 2024

View reviewed changes

convert2rhel/unit_tests/actions/post_conversion/kernel_boot_files_test.py

import pytest

import six

from convert2rhel import actions, checks, grub

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'grub' is not used.

kokesak approved these changes Aug 16, 2024

View reviewed changes

pr-watson force-pushed the migrate-post-conversion-kernel-boot-files branch from 0f68bdc to 3566e71 Compare August 16, 2024 13:35

hosekadam reviewed Aug 16, 2024

View reviewed changes

convert2rhel/actions/post_conversion/kernel_boot_files.py Outdated Show resolved Hide resolved

hosekadam approved these changes Aug 19, 2024

View reviewed changes

Venefilyn changed the title ~~[RHELC-1337] ] Port kernel_boot_files to the Action framework~~ [RHELC-1337] Port kernel_boot_files to the Action framework Aug 19, 2024

pr-watson and others added 11 commits August 19, 2024 13:08

[RHELC-1337] Port checks.check_kernel_boot_files() to Action framework

0b80b74

Update unit tests

8cdc035

Fix unit tests

081f070

Apply suggestions from code review

279a3ab

Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>

Update convert2rhel/actions/post_conversion/kernel_boot_files.py

b0dbabb

Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>

Update convert2rhel/actions/post_conversion/kernel_boot_files.py

e23dec3

Co-authored-by: Freya Gustavsson <freya@spytec.se>

Fix unit tests

01aedc6

Fix unit tests

937ba4e

Remove print

5dc22a1

[pre-commit.ci] auto fixes from pre-commit.com hooks

d353197

for more information, see https://pre-commit.ci

Update convert2rhel/actions/post_conversion/kernel_boot_files.py

1686a0e

Co-authored-by: Adam Hošek <hosek.adam@outlook.com>

Venefilyn force-pushed the migrate-post-conversion-kernel-boot-files branch from 5fa0b3c to 1686a0e Compare August 19, 2024 11:08

r0x0d added the merge-after-tests-ok label Aug 19, 2024

danmyway approved these changes Aug 19, 2024

View reviewed changes

danmyway merged commit 4286444 into oamg:main Aug 19, 2024
28 of 29 checks passed

This was referenced Aug 21, 2024

Bump to version 2.1.0 #1352

Merged

Bump to version 2.1.0 #1356

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RHELC-1337] Port kernel_boot_files to the Action framework #1301

[RHELC-1337] Port kernel_boot_files to the Action framework #1301

pr-watson commented Jul 11, 2024 •

edited

Loading

has-bot commented Jul 11, 2024

codecov bot commented Jul 11, 2024 •

edited

Loading

r0x0d left a comment

Venefilyn left a comment

kokesak commented Aug 15, 2024

kokesak commented Aug 15, 2024

kokesak left a comment

r0x0d commented Aug 16, 2024

r0x0d commented Aug 16, 2024

hosekadam left a comment

Venefilyn commented Aug 19, 2024

r0x0d commented Aug 19, 2024

danmyway commented Aug 19, 2024 •

edited

Loading

danmyway commented Aug 19, 2024

danmyway left a comment

[RHELC-1337] Port kernel_boot_files to the Action framework #1301

[RHELC-1337] Port kernel_boot_files to the Action framework #1301

Conversation

pr-watson commented Jul 11, 2024 • edited Loading

has-bot commented Jul 11, 2024

codecov bot commented Jul 11, 2024 • edited Loading

Codecov Report

r0x0d left a comment

Choose a reason for hiding this comment

Venefilyn left a comment

Choose a reason for hiding this comment

kokesak commented Aug 15, 2024

kokesak commented Aug 15, 2024

kokesak left a comment

Choose a reason for hiding this comment

r0x0d commented Aug 16, 2024

r0x0d commented Aug 16, 2024

hosekadam left a comment

Choose a reason for hiding this comment

Venefilyn commented Aug 19, 2024

r0x0d commented Aug 19, 2024

danmyway commented Aug 19, 2024 • edited Loading

danmyway commented Aug 19, 2024

danmyway left a comment

Choose a reason for hiding this comment

pr-watson commented Jul 11, 2024 •

edited

Loading

codecov bot commented Jul 11, 2024 •

edited

Loading

danmyway commented Aug 19, 2024 •

edited

Loading