Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1679] Fix of super(run()) call inside action #1332

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

hosekadam
Copy link
Member

@hosekadam hosekadam commented Aug 7, 2024

Move call of the function to be in the right place. This caused issues when the action return before reaching the super(run()) call.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Move call of the function to be in the right place. This caused issues
when the action return before reaching the super(run()) call.
@hosekadam hosekadam requested a review from a team as a code owner August 7, 2024 14:11
@hosekadam hosekadam added kind/bug-fix A bug has been fixed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Aug 7, 2024
@has-bot
Copy link
Member

has-bot commented Aug 7, 2024

/packit test --labels sanity


Comment generated by an automation.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (703e2b3) to head (007e349).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files          56       56           
  Lines        4784     4784           
  Branches      750      841   +91     
=======================================
  Hits         4589     4589           
  Misses        111      111           
  Partials       84       84           
Flag Coverage Δ
centos-linux-7 91.14% <100.00%> (ø)
centos-linux-8 92.06% <100.00%> (?)
centos-linux-9 92.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d
Copy link
Member

r0x0d commented Aug 7, 2024

/packit test --labels sanity

1 similar comment
@hosekadam
Copy link
Member Author

/packit test --labels sanity

@Venefilyn Venefilyn merged commit b7ddd96 into oamg:main Aug 12, 2024
33 of 36 checks passed
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants