hotfix/Fix backup_directory test fixture #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danmyway
commented
Aug 29, 2024
danmyway
commented
- pytest.skip was called, so the whole tests got skipped if conditions matched
danmyway
added
skip/changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 66 66
Lines 4997 4997
Branches 877 877
=======================================
Hits 4819 4819
Misses 101 101
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Tests passing (and running now), won't trigger the whole suite just for that. |
* pytest.skip was called, so the whole tests got skipped if conditions matched Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
danmyway
force-pushed
the
fix-backup_directory-fixture
branch
from
3618b13
to
81b0495
Compare
kokesak
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.