Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-1687] - conftest.py refactor - custom repos #1370

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[RHELC-1687] - conftest.py refactor - custom repos #1370

merged 1 commit into from
Sep 17, 2024

Conversation

kokesak
Copy link
Member

@kokesak kokesak commented Sep 9, 2024

Refactor how we use the custom repositories in conftest.py.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@kokesak kokesak added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. labels Sep 9, 2024
@has-bot
Copy link
Member

has-bot commented Sep 9, 2024

This PR does not require integration tests to be run.

Comment generated by an automation.

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (841cf50) to head (570a8b8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          66       66           
  Lines        4983     4983           
  Branches      877      877           
=======================================
  Hits         4801     4801           
  Misses        102      102           
  Partials       80       80
Flag Coverage Δ
centos-linux-7 91.76% <ø> (ø)
centos-linux-8 92.64% <ø> (ø)
centos-linux-9 92.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokesak kokesak added tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. and removed tests/skip This PR does not require integration tests to be run. labels Sep 9, 2024
@has-bot
Copy link
Member

has-bot commented Sep 9, 2024

/packit test --labels tier0

Comment generated by an automation.

@kokesak
Copy link
Member Author

kokesak commented Sep 10, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented Sep 11, 2024

/packit build

@kokesak
Copy link
Member Author

kokesak commented Sep 11, 2024

/packit test --labels tier0

@kokesak kokesak marked this pull request as ready for review September 12, 2024 06:40
@kokesak kokesak requested a review from a team as a code owner September 12, 2024 06:40
@kokesak
Copy link
Member Author

kokesak commented Sep 12, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented Sep 16, 2024

/packit test --labels tier0

SerCantus
SerCantus approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@SerCantus SerCantus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I have a small comment but it is not related to the change so approved 👍

tests/integration/conftest.py
system_version = SystemInformationRelease.version

# Default RHEL-7 repositories
repos = ["rhel-7-server-rpms", "rhel-7-server-optional-rpms", "rhel-7-server-extras-rpms"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is rhel-7-server-supplementary-rpms repo needed to test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have never used this repository for testing. It can be added. Have you seen it specified somewhere in the documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this PR, we can enable another repository in the following PRs

@kokesak kokesak merged commit 2bd5c4f into oamg:main Sep 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerCantus SerCantus SerCantus approved these changes

@danmyway danmyway Awaiting requested review from danmyway danmyway is a code owner automatically assigned from oamg/conversions-qe

Assignees
No one assigned
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kokesak @has-bot @SerCantus