Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1756] Remove legacy/RHEL 5 GPG key #1418

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Nov 1, 2024

Remove the RPM-GPG-KEY-redhat-legacy-release that was used to verify signature of RHEL 5 rpms. Convert2rhel no longer allows converting to RHEL 5 hence there's no need to bundle the key in the convert2rhel rpm and import the key during the conversion.

Red Hat is using a different key ("release key 2") to sign packages on RHEL 6/7/8/9. Convert2rhel has been bundling and importing this release key 2 for a long time.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@bocekm bocekm requested a review from a team as a code owner November 1, 2024 19:13
@bocekm bocekm added tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. kind/refactor labels Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (7be034f) to head (7b9d468).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1418   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files          72       72           
  Lines        5182     5182           
  Branches      896      896           
=======================================
  Hits         4980     4980           
  Misses        119      119           
  Partials       83       83           
Flag Coverage Δ
centos-linux-7 91.62% <ø> (ø)
centos-linux-8 92.47% <ø> (ø)
centos-linux-9 92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@has-bot
Copy link
Member

has-bot commented Nov 1, 2024

/packit test --labels sanity


Comment generated by an automation.

Remove the legacy GPG public key that was used to verify RHEL 5 packages
that were signed with the private part of the key.
Convert2rhel no longer allows converting to RHEL 5 hence there's no need
to bundle the key in the convert2rhel rpm and import it during the
conversion.
Red Hat is using a different key ("release key 2") to sign packages on
RHEL 6/7/8/9. Convert2rhel has been bundling and importing this release
key 2 for a long time.
@Venefilyn Venefilyn merged commit 0657d9b into oamg:main Nov 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants