Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve autotag and build rpm again #1420

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Venefilyn
Copy link
Member

This should hopefully tag and have all the variables accessible without
issue.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@Venefilyn Venefilyn added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. kind/infra Related to infrastructure changes labels Nov 4, 2024
@has-bot
Copy link
Member

has-bot commented Nov 4, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

Should determine the tag on its own without having to deal with sending
it back and forth. Hopefully this works.
@Venefilyn Venefilyn force-pushed the chore/autotag-rpm-build-split branch from 81fd229 to e1b6473 Compare November 4, 2024 14:50
@Venefilyn Venefilyn merged commit 2f31e3c into oamg:main Nov 4, 2024
7 of 8 checks passed
@Venefilyn Venefilyn deleted the chore/autotag-rpm-build-split branch November 4, 2024 14:50
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (8f71d5e) to head (e1b6473).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          72       72           
  Lines        5177     5177           
  Branches      896      896           
=======================================
  Hits         4976     4976           
  Misses        119      119           
  Partials       82       82           
Flag Coverage Δ
centos-linux-7 91.63% <ø> (ø)
centos-linux-8 92.49% <ø> (ø)
centos-linux-9 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/infra Related to infrastructure changes skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants