Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow underscore in package nevr regex #325

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

Venefilyn
Copy link
Member

The regex used to get problematic packages did not catch all package
name variants. Packages like mod_ldap has an underscore in it instead of
a dash. This fix makes it possible to fetch packages like it.

Copy link
Member

@bocekm bocekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend unit tests.

The regex used to get problematic packages did not catch all package
name variants. Packages like mod_ldap has an underscore in it instead of
a dash. This fix makes it possible to fetch packages like it.
@Venefilyn Venefilyn force-pushed the fix/allow-underscore-in-nevr-regex branch from cf186a9 to 6013bc9 Compare August 10, 2021 13:09
@bocekm bocekm merged commit 9457d14 into oamg:main Aug 10, 2021
@Venefilyn Venefilyn deleted the fix/allow-underscore-in-nevr-regex branch August 10, 2021 13:58
@bocekm bocekm mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants