-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KeyError when handling non-numbers in boot entries #391
Conversation
a6deeac
to
1f36170
Compare
Adding new entries to the # /dev/vda1 is the name of the vagrant disk
efibootmgr -c -b 000A -d /dev/vda1 -p 1 -l "\EFI\centos\shimx64.efi" -L "CentOS 8"
efibootmgr -c -b 000B -d /dev/vda1 -p 1 -l "\EFI\centos\shimx64.efi" -L "CentOS 8"
efibootmgr -c -b 000C -d /dev/vda1 -p 1 -l "\EFI\centos\shimx64.efi" -L "CentOS 8"
efibootmgr -c -b 00A2 -d /dev/vda1 -p 1 -l "\EFI\centos\shimx64.efi" -L "CentOS 8"
efibootmgr -c -b A2A2 -d /dev/vda1 -p 1 -l "\EFI\centos\shimx64.efi" -L "CentOS 8"
... Test outputs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change to me. +1
1f36170
to
28bc070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewd
6fa7681
to
9109be2
Compare
The error happened because of the lack of a rule for the BootEntries parser, before it only considered numbers between 0-9. However, the output of efibootmgr can contain numbers and letters, for example `000A` is a valid output. Jira reference: https://issues.redhat.com/browse/OAMG-6166 Bugzilla reference (If any): https://bugzilla.redhat.com/show_bug.cgi?id=2027686
9109be2
to
b81e90d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The error happened because of the lack of a rule for the BootEntries parser,
before it only considered numbers between 0-9. However, the output of efibootmgr
can contain numbers and letters, for example,
000A
is a valid output.Jira reference: https://issues.redhat.com/browse/OAMG-6166
Bugzilla reference (If any): https://bugzilla.redhat.com/show_bug.cgi?id=2027686