Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2 #742

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Bump version to 1.2 #742

merged 1 commit into from
Feb 22, 2023

Conversation

Venefilyn
Copy link
Member

@Venefilyn Venefilyn commented Feb 20, 2023

What's Changed

Enhancements 🎉

Security Hardening 🔒

Bug Fixes 🐛

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 92.85% // Head: 92.85% // No change to project coverage 👍

Coverage data is based on head (8985b28) compared to base (3504205).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          24       24           
  Lines        3329     3329           
  Branches      583      583           
=======================================
  Hits         3091     3091           
  Misses        171      171           
  Partials       67       67           
Flag Coverage Δ
centos-linux-7 88.19% <100.00%> (ø)
centos-linux-8 89.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
convert2rhel/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Venefilyn Venefilyn marked this pull request as draft February 20, 2023 13:52
Copy link
Member

@bocekm bocekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR description a bit to better describe the changes from the user POV.
Please also mention in the PR description the #723, #721, and #725 that will land in the release as well.

packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
packaging/convert2rhel.spec Outdated Show resolved Hide resolved
@bocekm
Copy link
Member

bocekm commented Feb 22, 2023

Please also mention in the PR description the #723, #721, and #725 that will land in the release as well.

Done.

@Venefilyn Venefilyn marked this pull request as ready for review February 22, 2023 15:17
@Venefilyn Venefilyn added the skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. label Feb 22, 2023
@bocekm bocekm merged commit ccf96a6 into oamg:main Feb 22, 2023
@Venefilyn Venefilyn deleted the release/v1.2 branch October 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants