[RHELC-878] Remove 8.4 from supported EUS versions #808

pr-watson · 2023-04-12T14:13:36Z

This PR removes the CentOS 8.4 EUS repos and their links to integration tests

Checklist

PR has been tested manually in a VM (either author or reviewer)
Jira issue has been made public if possible
[RHELC-] is part of the PR title
GitHub label has been added to help with Release notes
PR title explains the change from the user's point of view
Code and tests are documented properly
The commits are squashed to as few commits as possible (without losing data)
When merged: Jira issue has been updated to Release Pending if relevant

pr-watson · 2023-04-13T20:03:05Z

@danmyway since this PR removes RHEL 8.4 repos I believe the integration test for centos-8.4 need to be updated to use centos-8.6.

codecov · 2023-04-13T20:05:47Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2aa5c04) 94.01% compared to head (83a50bc) 94.01%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          40       40           
  Lines        3808     3808           
  Branches      678      678           
=======================================
  Hits         3580     3580           
  Misses        162      162           
  Partials       66       66

Flag	Coverage Δ
centos-linux-7	`88.97% <100.00%> (ø)`
centos-linux-8	`89.60% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
convert2rhel/systeminfo.py	`96.92% <100.00%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

r0x0d · 2023-04-18T12:13:11Z

@pr-watson, I think you can drop the 8.4 versions from packit too. @danmyway, do you agree?

danmyway · 2023-04-18T17:21:47Z

@pr-watson, I think you can drop the 8.4 versions from packit too. @danmyway, do you agree?

I agree with dropping it from the config.
However, I have a question about a timeline for this PR - will this get merged ASAP?
Are we dropping the upstream verifications for 8.4 right now?
I suppose we won't do regression testing for the 1.3 given the RHEL 8.4 goes of out of Extended Update Support (EUS) by the time of the release.
But IMO keeping the 8.4 verifications live until May, 31st seems reasonable to me.
Again, remove it from the config in this PR at your will, I am not opposed to that at all.
Thoughts @SpyTec @bocekm ?

pr-watson · 2023-04-18T17:47:43Z

@pr-watson, I think you can drop the 8.4 versions from packit too. @danmyway, do you agree?

I agree with dropping it from the config. However, I have a question about a timeline for this PR - will this get merged ASAP? Are we dropping the upstream verifications for 8.4 right now? I suppose we won't do regression testing for the 1.3 given the RHEL 8.4 goes of out of Extended Update Support (EUS) by the time of the release. But IMO keeping the 8.4 verifications live until May, 31st seems reasonable to me. Again, remove it from the config in this PR at your will, I am not opposed to that at all. Thoughts @SpyTec @bocekm ?

My PR for removing the 8.4 repos from Dogfood servers has been postponed for merging till May 31, 2023, so I assume the same would apply for this PR.

Venefilyn · 2023-04-18T18:30:19Z

For dogfood servers it makes sense as we want to be able to test against it until last second. However, I don't think we need to block this pr. We have the release branch if we need to release something urgently

Packit is also related to testing so I'd want to keep that for now, at least until we drop support for 8.4. But I assume that would cause issues for all PRs right?

danmyway · 2023-04-18T20:27:52Z

For dogfood servers it makes sense as we want to be able to test against it until last second. However, I don't think we need to block this pr. We have the release branch if we need to release
something urgently

Packit is also related to testing so I'd want to keep that for now, at least until we drop support for 8.4. But I assume that would cause issues for all PRs right?

If we would merge this PR, we need to remove the 8.4 from Packit config, otherwise most of the CentOS 8.4 pipeline will fail as you say @SpyTec.
So in case we want to drop the upstream verifications now, let me know and I will also remove all the 8.4 related code from tests.

Venefilyn · 2023-04-18T20:29:05Z

If we would merge this PR, we need to remove the 8.4 from Packit config, otherwise most of the CentOS 8.4 pipeline will fail as you say

That's what I feared. Then we should wait with this PR too and do Packit together with this PR

danmyway · 2023-04-19T08:35:38Z

That's what I feared. Then we should wait with this PR too and do Packit together with this PR

Cool, thank you for the clarification.
I can take care of it @pr-watson, and I will also remove the 8.4 related test code.

pr-watson · 2023-04-19T13:28:00Z

That's what I feared. Then we should wait with this PR too and do Packit together with this PR

Cool, thank you for the clarification. I can take care of it @pr-watson, and I will also remove the 8.4 related test code.

Thanks @danmyway!

r0x0d · 2023-04-25T19:40:20Z

There is a PR that removes the 8.4 support from our internal vagrant workflow. The PR will be merged once this one is merged, so, this is a future warning for myself.

danmyway · 2023-05-02T10:35:34Z

...tegration/tier1/removed-pkgs-centos-85/ansible/install_removed_pkgs_from_centos_85_repos.yml

Hey, @pr-watson, I will revert changes in this file.
We need to add and enable the 8.4 repos, because we are looking for a package, which is not present in 8.5 repos anymore.

@danmyway understood

plans/tier1.fmf

danmyway · 2023-05-02T11:29:00Z

I have rebased and modified the tests @pr-watson

kokesak

Just one small thing in the comment. Otherwise, the QE side looks good!

tests/integration/tier0/latest-kernel-check/test_latest_kernel_check.py

r0x0d

Just minor comments, but otherwise, it is looking good!

convert2rhel/unit_tests/conftest.py

convert2rhel/unit_tests/pkgmanager/handlers/dnf/dnf_test.py

convert2rhel/unit_tests/repo_test.py

convert2rhel/unit_tests/systeminfo_test.py

tests/ansible_collections/roles/add-custom-repos/main.yml

pr-watson · 2023-05-15T16:06:25Z

@r0x0d thanks for the suggestions

r0x0d · 2023-05-22T12:49:27Z

This needs a rebase @pr-watson.

danmyway · 2023-06-06T12:26:37Z

Rebased, conflicts resolved, ready to merge

Unit tests failed

* remove all 8.4 related code Signed-off-by: Daniel Diblik <ddiblik@redhat.com>

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>

convert2rhel/unit_tests/subscription_test.py

r0x0d

Looks good!

Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>

for more information, see https://pre-commit.ci

* [RHELC-878] Remove 8.4 from supported EUS versions * Modify tests * remove all 8.4 related code Signed-off-by: Daniel Diblik <ddiblik@redhat.com> * Address review comments Signed-off-by: Daniel Diblik <ddiblik@redhat.com> * Apply suggestions from code review Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Daniel Diblik <ddiblik@redhat.com> Co-authored-by: Daniel Diblik <ddiblik@redhat.com> Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

pr-watson force-pushed the remove-8.4 branch from f56215d to bd49b10 Compare April 14, 2023 15:11

danmyway self-assigned this Apr 19, 2023

danmyway reviewed May 2, 2023

View reviewed changes

plans/tier1.fmf Outdated Show resolved Hide resolved

danmyway force-pushed the remove-8.4 branch from bd49b10 to a000766 Compare May 2, 2023 11:28

Venefilyn added the kind/feature New feature or request label May 2, 2023

danmyway force-pushed the remove-8.4 branch 3 times, most recently from a8cf6e3 to 9bc1641 Compare May 10, 2023 09:52

kokesak reviewed May 15, 2023

View reviewed changes

tests/integration/tier0/latest-kernel-check/test_latest_kernel_check.py Outdated Show resolved Hide resolved

danmyway force-pushed the remove-8.4 branch from 9bc1641 to bbed280 Compare May 15, 2023 09:59

r0x0d requested changes May 15, 2023

View reviewed changes

pr-watson force-pushed the remove-8.4 branch from 436fdb8 to df8f896 Compare May 22, 2023 19:01

danmyway force-pushed the remove-8.4 branch 2 times, most recently from f7edbfd to acc4e00 Compare June 6, 2023 12:19

r0x0d previously approved these changes Jun 6, 2023

View reviewed changes

pr-watson force-pushed the remove-8.4 branch from acc4e00 to 5a452ff Compare June 6, 2023 15:50

pr-watson and others added 3 commits June 6, 2023 11:59

[RHELC-878] Remove 8.4 from supported EUS versions

61b660c

Modify tests

9096eb3

* remove all 8.4 related code Signed-off-by: Daniel Diblik <ddiblik@redhat.com>

Address review comments

73a8dcb

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>

pr-watson force-pushed the remove-8.4 branch from 5a452ff to cf998b5 Compare June 6, 2023 16:02

r0x0d reviewed Jun 6, 2023

View reviewed changes

convert2rhel/unit_tests/subscription_test.py Outdated Show resolved Hide resolved

r0x0d approved these changes Jun 6, 2023

View reviewed changes

Apply suggestions from code review

6a56c96

Co-authored-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>

pr-watson force-pushed the remove-8.4 branch from 45d3c58 to 6a56c96 Compare June 6, 2023 19:45

[pre-commit.ci] auto fixes from pre-commit.com hooks

83a50bc

for more information, see https://pre-commit.ci

pr-watson merged commit 6103236 into oamg:main Jun 6, 2023

bocekm mentioned this pull request Aug 28, 2023

Bump version to 1.4.0 #893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RHELC-878] Remove 8.4 from supported EUS versions #808

[RHELC-878] Remove 8.4 from supported EUS versions #808

pr-watson commented Apr 12, 2023 •

edited by danmyway

Loading

pr-watson commented Apr 13, 2023

codecov bot commented Apr 13, 2023 •

edited

Loading

r0x0d commented Apr 18, 2023

danmyway commented Apr 18, 2023

pr-watson commented Apr 18, 2023

Venefilyn commented Apr 18, 2023

danmyway commented Apr 18, 2023

Venefilyn commented Apr 18, 2023 •

edited

Loading

danmyway commented Apr 19, 2023

pr-watson commented Apr 19, 2023

r0x0d commented Apr 25, 2023

danmyway May 2, 2023

pr-watson May 2, 2023

danmyway commented May 2, 2023

kokesak left a comment

r0x0d left a comment

pr-watson commented May 15, 2023

r0x0d commented May 22, 2023

danmyway commented Jun 6, 2023

r0x0d left a comment

[RHELC-878] Remove 8.4 from supported EUS versions #808

[RHELC-878] Remove 8.4 from supported EUS versions #808

Conversation

pr-watson commented Apr 12, 2023 • edited by danmyway Loading

pr-watson commented Apr 13, 2023

codecov bot commented Apr 13, 2023 • edited Loading

Codecov Report

r0x0d commented Apr 18, 2023

danmyway commented Apr 18, 2023

pr-watson commented Apr 18, 2023

Venefilyn commented Apr 18, 2023

danmyway commented Apr 18, 2023

Venefilyn commented Apr 18, 2023 • edited Loading

danmyway commented Apr 19, 2023

pr-watson commented Apr 19, 2023

r0x0d commented Apr 25, 2023

danmyway May 2, 2023

Choose a reason for hiding this comment

pr-watson May 2, 2023

Choose a reason for hiding this comment

danmyway commented May 2, 2023

kokesak left a comment

Choose a reason for hiding this comment

r0x0d left a comment

Choose a reason for hiding this comment

pr-watson commented May 15, 2023

r0x0d commented May 22, 2023

danmyway commented Jun 6, 2023

r0x0d left a comment

Choose a reason for hiding this comment

pr-watson commented Apr 12, 2023 •

edited by danmyway

Loading

codecov bot commented Apr 13, 2023 •

edited

Loading

Venefilyn commented Apr 18, 2023 •

edited

Loading