[RHELC-1133] Fix colors in the text-based analysis log being reversed from what it should be #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 41 41
Lines 4142 4142
Branches 737 737
=======================================
Hits 3894 3894
Misses 177 177
Partials 71 71
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
abadger
changed the title
abadger
added
kind/bug-fix
…it should be. convert2rhel.logger uses a boolean to tell whether to turn colors *off* while we were using a boolean to turn colors *on* in the assessment log. Made it so both turn colors off now.
abadger
force-pushed
the
fix-colors-in-report
branch
from
92138bf
to
f625ac7
Compare
|
/packit build |
r0x0d
approved these changes
Sep 14, 2023
|
/packit test --labels tier0 |
|
/packit build |
|
/packit test --labels tier0 |
hosekadam
approved these changes
Sep 25, 2023
|
/packit test --labels tier0 |
|
@danmyway Is this okay to merge or do you think it needs QE verification and therefore we shouldn't merge it until 1.6 or 1.7? This was not noticed by customers but it affects the output of the assessment report (whether ANSI escape sequences for colors appear in the report or not). |
8 tasks
bocekm
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert2rhel.logger uses a boolean to tell whether to turn colors off while we were using a boolean to turn colors on in the assessment log. Made it so both turn colors off now.
Jira Issues: RHELC-1133
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant