Draft: Add profiling to leapp and snactor #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on some machines the run of the leapp / snactor is too slow. Especially framework itself should be fast but sometimes the time differences are in order of tens seconds. From this point, it seems useful to be able to start profilling based on the env variable when it is needed.
Co-Authored-By: pirat89 <xstodu05@gmail.com>
|
Can one of the admins verify this patch? |
The same profiling code also works in leapp with minimal changes. It could be useful, although it shows more than 90% of the time spent in posix.waitpid. Also import StringIO from six instead.
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the If you want to re-run tests or request review, you can use following commands as a comment:
Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
A value of 1 is still required to turn profiling on.
oh man
drehak
force-pushed
the
feature/profiling
branch
from
eb8fc97
to
646755a
Compare
vinzenz
reviewed
Nov 3, 2020
Comment on lines
+19
to
+20
| os.environ['LEAPP_CPROFILE'] = os.environ.get('LEAPP_CPROFILE', '0') | ||
| profile_enabled = os.environ['LEAPP_CPROFILE'] == '1' |
There was a problem hiding this comment.
Suggested change
| os.environ['LEAPP_CPROFILE'] = os.environ.get('LEAPP_CPROFILE', '0') | |
| profile_enabled = os.environ['LEAPP_CPROFILE'] == '1' | |
| profile_enabled = os.environ.get('LEAPP_CPROFILE', '0') == '1' |
vinzenz
reviewed
Nov 3, 2020
Comment on lines
+80
to
+81
| os.environ['LEAPP_CPROFILE'] = os.environ.get('LEAPP_CPROFILE', '0') | ||
| profile_enabled = os.environ['LEAPP_CPROFILE'] == '1' |
There was a problem hiding this comment.
Suggested change
| os.environ['LEAPP_CPROFILE'] = os.environ.get('LEAPP_CPROFILE', '0') | |
| profile_enabled = os.environ['LEAPP_CPROFILE'] == '1' | |
| profile_enabled = os.environ.get('LEAPP_CPROFILE', '0') == '1' |
zhukovgreen
reviewed
Nov 3, 2020
drehak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up where #482 left off. For science, profit and fun.
LEAPP_CPROFILE=1turns on the profiler and shows stats after a successful execution. Maybe an option would be better instead...